adobecom / bacom Goto Github PK

The locale nav tool was added to milo. Now we need to update our sidekick config so that it's available in bacom
adobecom/milo#556

Add preflight to tools config so authors can use it on bacom

adobecom/milo#417

Update the Contributing doc. Link to it in the readme

Goal for test coverage is 100%. Check the code coverage report and add any necessary tests

Currently, only the Stats block shows up in the library. Make sure the other bacom blocks get added too:

• Check the block examples in the /library folder to make sure they're up to date
• (Might want to organize them in a /blocks folder like Milo)
• Add any new blocks
• Update library.xlsx

Note: I'm adding this issue after-the-fact in order to track the work we did.

The code coverage bot wasn't accurate. It was showing 100% coverage when we knew parts of the codebase (like Stats) didn't have any tests.

Note: I'm adding this issue after-the-fact in order to track the work we did.

Add test for Stats block for 100% Stats block coverage

Note: I'm adding this issue after-the-fact in order to track the work we did.

Add husky pre-commit hook like we have in northstar and make sure the linter runs. Should also have a way to bypass.

Assess actions taken by David Catalan in Milo repo to improve linting of test code and implement any that would be useful in bacom adobecom/milo#324

Add codeowners file to the project.

https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners

Update pre-commit hook to run tests in addition to existing linters

Add a check to our PRs that enforced PR labels like we see in Milo. For the check to pass, the PR will need to have either the "verified" or "trivial" label.

Files:

• https://github.com/adobecom/milo/blob/main/.github/workflows/enforce-labels.yml

Add codeql to our PR checks like we see in Milo

Files:

• https://github.com/adobecom/milo/blob/main/.github/workflows/codeql.yml
• https://github.com/adobecom/milo/blob/main/.github/codeql/codeql-config.yml

Note: Our paths to ignore might be different than Milo's

Note: I'm adding this issue after-the-fact in order to track the work we did.

Add a PR template. Can use the one from Milo

Note: I'm adding this issue after-the-fact in order to track the work we did.

Add the code coverage bot to run on our PRs like in Milo

Because of the VPN changes we can not get lighthouse scores for PRs.
Need to see how to get around this issue or remove the lighthouse check.

We should add a lint checker to PRs to maintain consistent code style.
See https://github.com/hparra/milo/blob/main/.github/workflows/run-lint.yaml

Currently, we don't have anything in our wiki. Add at least an introductory page and any others you have content for. I suggest adding links to the readme and contributing docs that we've already flushed out.

The readme still includes info for Milo College. Update it to include information relevant to bacom