Expected Behaviour

We need to be able to use the SDK on a server that is running behind a proxy.
We could not find any documentation that specifies how a proxy could be configured for the Target HTTP client.

Actual Behaviour

Running the SDK behind a proxy times out and throws a NullPointerException. Running the same code on a server with direct internet connection works well.

Steps to Reproduce

Run the SDK on any PC that is behind a corporate firewall and that requires a proxy configuration to allow external internet calls.

Platform and Version

Java 1.8
Adobe Target SDK 1.0.1

Sample Code that illustrates the problem

Running this line behind in a network that requires a proxy would timeout and throw a null pointer exception.

TargetDeliveryResponse targetDeliveryResponse = targetClient.getOffers(targetDeliveryRequest);

Logs taken while reproducing problem

Exception in thread "main" com.adobe.target.edge.client.service.TargetRequestException
	at com.adobe.target.edge.client.DefaultTargetClient.getOffers(DefaultTargetClient.java:46)
	at TargetSDKTest.main(TargetSDKTest.java:48)
Caused by: java.lang.NullPointerException
	at com.adobe.target.edge.client.http.TargetMetrics.lambda$begin$0(TargetMetrics.java:36)
	at kong.unirest.apache.ApacheClient.request(ApacheClient.java:132)
	at kong.unirest.BaseRequest.asObject(BaseRequest.java:230)
	at com.adobe.target.edge.client.http.DefaultTargetHttpClient.execute(DefaultTargetHttpClient.java:69)
	at com.adobe.target.edge.client.http.TargetHttpClientLoggingDecorator.execute(TargetHttpClientLoggingDecorator.java:34)
	at com.adobe.target.edge.client.service.DefaultTargetService.executeRequest(DefaultTargetService.java:59)
	at com.adobe.target.edge.client.DefaultTargetClient.getOffers(DefaultTargetClient.java:43)
	... 1 more

Possible Fix

The code can be enhanced to enable the customers to set their proxy when needed. this could be achieved by making the following changes:

1- Create a new ClientProxyConfig class to hold the proxy details.

package com.adobe.target.edge.client;

public class ClientProxyConfig {
	private String address;
	private String port;
	private String userName;
	private String password;
	private boolean authProxy = false; 
	
	public ClientProxyConfig(String proxyAddress, String proxyPort) {
		this.address = proxyAddress;
		this.port = proxyPort;
	}
	
	public ClientProxyConfig(String address, String port, String userName, String password) {
		this.address = address;
		this.port = port;
		this.userName = userName;
		this.password = password;
		authProxy = true;
	}

	public String getAddress() {
		return address;
	}

	public String getPort() {
		return port;
	}

	public String getUserName() {
		return userName;
	}

	public String getPassword() {
		return password;
	}

	public boolean isAuthProxy() {
		return authProxy;
	}
}

2- Update the com.adobe.target.edge.client.ClientConfig class to have an instance of the ClientProxyConfig

private ClientProxyConfig proxy;

public ClientProxyConfig getProxy() {
	return proxy;
}

public void setProxy(ClientProxyConfig proxy) {
	this.proxy = proxy;
}

public boolean isProxyEnabled() {
	return proxy != null;
}

3- Update the constructor of the com.adobe.target.edge.client.http.DefaultTargetHttpClient class to have the following lines:

if (clientConfig.isProxyEnabled()) {
    ClientProxyConfig proxy = clientConfig.getProxy();
    if(proxy.isAuthProxy()) {
        unirestInstance.config().proxy(proxy.getAddress(), proxy.getPort, proxy.getUserName(), proxy.getPassword);
    } else {
        unirestInstance.config().proxy(proxy.getAddress(), proxy.getPort);
    }
}

There appears to be an issue with new users landing on the targeted page. The server-side implementation does not have an implementation for the Visitor API to get the ECID/MCID, thus causing a mismatch between Target and Analytics. Returning users with AMCV cookies already set do not appear to have an issue.

The example stats below are for a page that is mostly new users landing on it.

Expected Behaviour

A4T accurately tracks user data from server-side requests. # of views in experiences should mimic the total # of views of the given page.

Actual Behaviour

A4T is not attributing the appropriate experience for all views.

The following images were pulled from Analytics for the same time period. The page 'landing page:custom closets' is utilizing the server-side API and every user should be attributed an Experience. The total # of unique views should match between the two charts, as well as the # of submits (the conversion criteria).

Reproduce Scenario (including but not limited to)

Steps to Reproduce

Implement the target-java-sdk with analytics.
Create a Target Experience. Track the # of views of the page compared to the views of the experiences.

Platform and Version

• target-java-sdk v1.1.0
• Spring v4.3.25.RELEASE

Sample Code that illustrates the problem

We followed the sample provided for targetMcid.

The only difference being our integration through Launch. Visitor state is set to a JS variable which is propagated to the Visitor Service through Launch.

Logs taken while reproducing problem

New User Request

{
      "requestId": "1a6560bb-b963-44f5-8e59-802347f7f6d8",
      "context": {
        "channel": "web",
        "address": {
          "url": "https://www.containerstore.com/custom-closets"
        },
        "beacon": false
      },
      "experienceCloud": {
        "analytics": {
          "supplementalDataId": "02BC759D22D4FE7E-62749C19A3060DFA",
          "logging": "server_side",
          "trackingServer": "thecontainerstore.sc.omtrdc.net"
        }
      },
      "execute": {
        "pageLoad": {
          "parameters": {},
          "profileParameters": {}
        },
        "mboxes": []
      },
      "prefetch": {
        "views": [
          {
            "parameters": {},
            "profileParameters": {}
          }
        ],
        "mboxes": []
      },
      "notifications": []
    }

Returning User Request

{
  "requestId": "2d05b638-d461-4377-904b-247b403032de",
  "id": {
    "tntId": "749afadd-3570-4efd-9e6a-84cd2c892160.35_0",
    "marketingCloudVisitorId": "45913002719203183828537149552334816373"
  },
  "context": {
    "channel": "web",
    "address": {
      "url": "https://www.containerstore.com/custom-closets"
    },
    "beacon": false
  },
  "experienceCloud": {
    "analytics": {
      "supplementalDataId": "697825C548C84264-1FC0EB4BDBB0355A",
      "logging": "server_side",
      "trackingServer": "thecontainerstore.sc.omtrdc.net"
    }
  },
  "execute": {
    "pageLoad": {
      "parameters": {},
      "profileParameters": {}
    },
    "mboxes": []
  },
  "prefetch": {
    "views": [
      {
        "parameters": {},
        "profileParameters": {}
      }
    ],
    "mboxes": []
  },
  "notifications": []
}

Expected Behaviour

Impressions to increment in the Target interface.

Actual Behaviour

Impressions remain at 0 for Production and Development environments.

Reproduce Scenario (including but not limited to)

Issue a getOffers request

Steps to Reproduce

Platform and Version

1.1

Sample Code that illustrates the problem

Can provide in a more secure format.

Logs taken while reproducing problem

Can provide in a more secure format.