Provide a general summary of the issue here onClick should be able

onClick cannot be triggered using continuePropagation about react-spectrum HOT 3 OPEN

Ciavarella commented on May 24, 2024

onClick cannot be triggered using continuePropagation

from react-spectrum.

Comments (3)

sookmax commented on May 24, 2024

onClick is not triggered on parent when clicking a child onPress or onPressStart with continuePropagation.

As far as I can tell, only PressEvent handlers of the parent (a 'pressable' component, using usePress()) see the propagated event when PressEvent.continuePropagation() is called in the child (again, a 'pressable' component, using usePress()):

react-spectrum/packages/@react-aria/interactions/test/usePress.test.js

Lines 2896 to 2921 in b2c9961

    
           it('should allow propagation if continuePropagation is called', () => { 
        
             let outerPressMock = jest.fn(); 
        
             let innerPressMock = jest.fn().mockImplementation(e => e.continuePropagation()); 
        
             let res = render( 
        
               <Pressable 
        
                 onPressStart={outerPressMock} 
        
                 onPressEnd={outerPressMock} 
        
                 onPress={outerPressMock} 
        
                 onPressUp={outerPressMock}> 
        
                 <Pressable 
        
                   data-testid="test" 
        
                   onPressStart={innerPressMock} 
        
                   onPressEnd={innerPressMock} 
        
                   onPress={innerPressMock} 
        
                   onPressUp={innerPressMock}> 
        
                   inner 
        
                 </Pressable> 
        
               </Pressable> 
        
             ); 
        
             let el = res.getByTestId('test'); 
        
             start(el); 
        
             end(el); 
        
             expect(outerPressMock.mock.calls).toHaveLength(4); 
        
             expect(innerPressMock.mock.calls).toHaveLength(4); 
        
           });

The description of continuePropagation() also seems to say a similar thing:

react-spectrum/packages/@react-types/shared/src/events.d.ts

Lines 48 to 53 in b2c9961

    
             /** 
        
              * By default, press events stop propagation to parent elements. 
        
              * In cases where a handler decides not to handle a specific event, 
        
              * it can call `continuePropagation()` to allow a parent to handle it. 
        
              */ 
        
             continuePropagation(): void

from react-spectrum.

onClick cannot be triggered using continuePropagation about react-spectrum HOT 3 OPEN

Comments (3)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	it('should allow propagation if continuePropagation is called', () => {
	let outerPressMock = jest.fn();
	let innerPressMock = jest.fn().mockImplementation(e => e.continuePropagation());
	let res = render(
	<Pressable
	onPressStart={outerPressMock}
	onPressEnd={outerPressMock}
	onPress={outerPressMock}
	onPressUp={outerPressMock}>
	<Pressable
	data-testid="test"
	onPressStart={innerPressMock}
	onPressEnd={innerPressMock}
	onPress={innerPressMock}
	onPressUp={innerPressMock}>
	inner
	</Pressable>
	</Pressable>
	);

	let el = res.getByTestId('test');
	start(el);
	end(el);
	expect(outerPressMock.mock.calls).toHaveLength(4);
	expect(innerPressMock.mock.calls).toHaveLength(4);
	});

	/**
	* By default, press events stop propagation to parent elements.
	* In cases where a handler decides not to handle a specific event,
	* it can call `continuePropagation()` to allow a parent to handle it.
	*/
	continuePropagation(): void