Combobox Input requires hitting enter twice to submit a form about react-spectrum HOT 4 OPEN

Maybe we could modify

from react-spectrum.

Correct me if I'm wrong, but this issue is only a problem when both allowsCustomValue and allowsEmptyCollection are specified, right? I've noticed that if only allowsCustomValue is set, then the combobox would close automatically when the typed input doesn't match any of the items, and thus the form is submitted via a single enter keystroke.

So I'm not entirely sure if it's a good idea to add an additional logic in the above if-statement to handle this specific use case? since it makes sense to close the menu first (even if it's an empty one), and then submit the form?

Would there be a better way to deal with this?

from react-spectrum.

There could also be the case where the user's custom value is a substring of the combobox's dropdown values in which case the dropdown would be open still even if allowsEmptyCollection is false. Open to alternative ideas/opinions but it feels to me that as long as virtual focus isn't set within the dropdown then we can treat interactions as happening purely on the input element and thus we no longer need to prevent default.

from react-spectrum.

For now, I've added a workaround that adds a keypress event listener to the input and manually triggers a click on a submit button we have in our component if there's no focusedKey

from react-spectrum.