modify circleci to use rules described in adobe/project-helix#278

Is there a way for us to make it implicit, so that all properties within it just become the global scope within HTL? That way {it.request.path} would become simply {request.path}.

As mentioned in https://github.com/adobe/project-helix/issues/267, it should be super easy to write a pre.js without knowing the complexity of the pipeline.

suggest:

pipeline autodetects pre in simple form like:

module.exports = function pre(payload) {
  payload.resource.time = `${new Date()}`;
}

The current htl plugin is responsible for:

• turning the .htl into a javascript function that produces the html
• loading and executing the pre.js
• loading the pipeline
• wrapping everything into an openwhisk action

The plugin should only be responsible to create the JS function, and the rest should be handled by hlx build. this allows to use other scripts like JST or simple transformers needed for JSON rendering. see adobe/helix-cli#70

the current function returns:

{
  body: ...
}

but should better return:

{
   response: {
      body: ...
   }
}

to be conform with https://github.com/adobe/helix-pipeline/blob/master/docs/context.schema.json

The dependency snyk was updated from 1.145.0 to 1.146.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

snyk is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Your Greenkeeper Bot 🌴

as discussed in adobe/helix-cli#295,
the processing of the HT(M)L causes more harm than benefit, and we revert #16 again.

the inlined code looks a bit ugly...better to use a file.

https://github.com/adobe/parcel-plugin-htl/blob/0.3.0-class/HTLAsset.js#L57-L90

The devDependency @semantic-release/npm was updated from 5.1.6 to 5.1.7.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

@semantic-release/npm is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

⏳  Building html.htl...
🚨  /code/project-helix/prototypes/parcel-plugin-pipeline/test/integration/htl-only/src/html.htl: ENOENT: no such file or directory, open '/code/project-helix/prototypes/parcel-plugin-pipeline/test/integration/htl-only/node_modules/@adobe/parcel-plugin-htl/node_modules/@adobe/htlengine/src/compiler/JSRuntimeTemplate.js'
    at Object.fs.openSync (fs.js:646:18)
    at Object.fs.readFileSync (fs.js:551:33)
    at TransientCompiler.compile (/code/project-helix/prototypes/parcel-plugin-pipeline/test/integration/htl-only/node_modules/@adobe/parcel-plugin-htl/HTLAsset.js:41:23)
    at HTLAsset.parse (/code/project-helix/prototypes/parcel-plugin-pipeline/test/integration/htl-only/node_modules/@adobe/parcel-plugin-htl/HTLAsset.js:64:30)
    at HTLAsset.parseIfNeeded (/code/project-helix/prototypes/parcel-plugin-pipeline/test/integration/htl-only/node_modules/parcel-bundler/src/Asset.js:62:29)
    at <anonymous>

Depends on adobe/htlengine#3

since the htl scripts are using an already safe markup from the helix-pipeline, it is safe to use the unsafe markup context:-)

see adobe/helix-pipeline#353
see adobe/helix-pipeline#356

Leverage source map support available in htlengine, v1.0.4

The current test setup means we have to maintain two test directories and test cases cannot be merged.

It would be better to call Parcel programmatically and run everything in one single mocha command.

We need good examples, tests and documentation of pre.js handling, so that @kptdobe can get it to work.

Right now, the tests don't cover pre.js and the function signature might need some explanation.

use semantic-release plugin to simplify release management

The dependency @adobe/htlengine was updated from 2.1.3 to 2.1.4.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

@adobe/htlengine is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Your Greenkeeper Bot 🌴

The dependency parcel-bundler was updated from 1.9.7 to 1.10.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

parcel-bundler is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Your Greenkeeper Bot 🌴

[email protected] now supports dom document. the dom factory should be enabled if the context contains such a document.

Regression introduced by #19

Run:

hlx demo test
cd test

Edit src/html.htl and add this line anywhere in the file:

<a href="${it.request.path}">${it.request.path}</a>

Run hlx up

-> the HTML output of the link is: <a href="/$%7Bit.request.path%7D">/index.html</a>

The tests do not terminate. after investigation, I think this has something to do with the parcel bundler that doesn't shutdown all the workers.

see adobe/helix-cli#743

suggest

• register both: payload and context as global variable
• create Proxy around payload that report deprecation warning if used
• deprecate in next major release.

@trieloff WDYT?

The devDependency snyk was updated from 1.170.0 to 1.171.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

snyk is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

In order to avoid parameter re-assign, it should be possible to return the new payload. eg:

Simple

function pre(payload) {
  const myPayload = Object.assign({}, payload);
  myPayload.resource.time = `${new Date()}`;
  return myPayload;
}

Async

async function pre(payload) {
  const myPayload = Object.assign({}, payload);
  myPayload.resource.time = `${new Date()}`;
  return myPayload;
}

Promise

function pre(payload) {
  return new Promise(resolve => {
    const myPayload = Object.assign({}, payload);
    myPayload.resource.time = `${new Date()}`;
    resolve(myPayload);
  });
}

Similar how parcel processes linked assets in html source (i.e. relative links to CSS/JS),
the htl plugin should also process this similarly.