Code Monkey home page Code Monkey logo

blog's Introduction

blog's People

Contributors

amauch-adobe avatar auniverseaway avatar davidnuescheler avatar dominique-pfister avatar eltotofuerte avatar fkakatie avatar fullcolorcoder avatar jckautzmann avatar kptdobe avatar lucanerlich avatar mokimo avatar qiyundai avatar rofe avatar seanchoi-dev avatar so1ene avatar stefan-guggisberg avatar toka1300 avatar trieloff avatar williambsm avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

blog's Issues

"Copy/paste" the business site code into this repo

This blog site will be based on the same code base than https://github.com/adobe/business-website. We'll need to decide a time where we copy / paste the code and start diverging the 2 code bases.

This issue acts as a container to reference all business site issues that are "blocking" this copy / paste, i.e. some todos that need to be done before we start diverging the 2 code bases (to avoid duplication of the work).

Note that it is given that after the copy / paste, we'll necessary have to do fixes in the 2 code bases, the idea here is the minimise the effort.

Authors can be "links"

Check page: https://main--blog--adobe.hlx3.page/ko/publish/2021/10/21/digital-transformation-determining-the-future-of-healthcare

The author links points to https://main--blog--adobe.hlx3.page/ko/authors/------.

2 issues here:

  1. During the content import, the "author" is converted into a meta property. But in the source document, the author can be a link: this is how we solved the problem when the author link cannot be deducted from author name (especially true in KO and JP or for authors with special characters in the name). The link gets lost during the import (I have added now the link on the example page to observe the next issue).
  2. If we change the author property in the metadata table to be a link, the link is removing during rendering.

Several options:

  1. Add support for a link in the author metadata property in Word - the link should then be outputted as another meta because the author meta tag does not support it. There is no standard or OG representing it. We should invent one (author:url ? like in og:image:url). The pipeline should then be extended.
  2. Split the 2, have another row with author:link or authorLink (no necessarily user friendly).
  3. Create a new block for it (really complicated).

In all cases, the importer must be adjusted.

@fkakatie @davidnuescheler @rofe WDYT ?

Javascript error and "broken" layout with side-by-side images

Open https://main--blog--adobe.hlx3.page/en/publish/2021/04/22/photoshop-and-adobe-experience-manager-accelerating-creativity-through-apis

Check the Javascript error:

Auto Blocking failed TypeError: Cannot read properties of null (reading 'insertBefore')
    at scripts.js:537
    at Array.forEach (<anonymous>)
    at buildImageBlocks (scripts.js:532)
    at buildAutoBlocks (scripts.js:654)
    at decorateMain (scripts.js:975)
    at loadEager (scripts.js:1081)
    at decoratePage (scripts.js:1158)
    at scripts.js:1163

This is cause by the 2 side-by-side images (the phone screenshots) in the source document. They do not end-up in a block.

This was somehow supported on the hl2 version: https://blog.adobe.com/en/publish/2021/04/22/photoshop-and-adobe-experience-manager-accelerating-creativity-through-apis.html:

image

At least, there should not be an error.

[Content] Add Title and Description to metadata

Matt would like Title and Description to be "mandatory" metadata properties. In order to influence authors who will copy/paste content from older articles, we should add the Title and Description to the metadata in all the cases.

Remove console.warn

Currently used to debugged and track invalid content during content migration.

[gnav][footer] Links take you to blog.adobe.com

The gnav and the region picker links currently point to blog.adobe.com which makes it impossible to stay on the same host and navigate the site.
The links must be adjusted when not on the production environment.

[Analytics] Merge theblog analytics code

The current Analytics code in the repo is the one from the business website. We need to take theblog analytics code (which is currently evolving) and copy it in this repo.

Article category can be a non-visible one

Follow up from: #10

At the moment, the category of an article is the first tag of the list.
Problem: an author can specify a tag defined in the taxonomy document as non visible. Consequence: the tag should never appear on the site. The category is usually part of the LCP block, thus we cannot check early enough thus no client side check is performed.

This happens today in the content quite a lot and this is handle client side on the current site. Several options:

  1. post LCP and once the taxonomy is loaded, we replace the category by the correct one
  2. we load the taxonomy before LCP thus we can check (might have an impact on the score)
  3. we do nothing client side (we can still fix the imported content). The tagger is now always moving a visible category first but if an author insists a non-visible category may appear. The link is set to # if this is the case.

Resubmit sitemap with the new extensionless canonicals

With the hlx3 migration, we are getting rid of the .html in the urls (see #7). Sitemap will be re-generated and will not contain the extensions (see #46).

Once the site will be migrated and the sitemaps will be regenerated, we will need to re-submit them to Google.
We need to find who has access to do so.

Monitoring setup

Pre-go-live

  • Adapt monitoring automation to new site

Go-live

  • Disable monitors prior to go-live switch
  • Run new monitoring automation
  • Verify and enable updated monitors

Post-go-live:

  • Update static homepage response

Migrate taxonomy

The taxonomy is handled differently with business-website. We should migrate the taxonomy from theblog site.

  • Visible vs non visible tags
  • Show parent tags
  • Exclude logic
  • ...

This depends on #1.

SEO recommendations

List of recommendations for SEO purpose. For now, this is just the raw list, we might need to define the ones we don't want to do.

  • Homepage changes
    • Add H1 title - done with hlx3 migration
    • Add sub text below the H1 title - styling / CSS missing
    • Use image alt text for card images - done during hlx3 migration (image alt text indexed)
  • Topic page changes
    • Add sub text (155 characters short description) - styling / CSS missing
  • Author page changes
    • Use H1 instead of H2 - will done with #53

Handle .html vs no .html

Current link to articles in content, especially in promotions, featured / recommended articles contains .html. But requesting an article with a .html returns a 404.
While there is some thing that needs to happen globally, while we import the content, we can certainly remove the .html.
Also, we could add client side logic to remove it.

[Content] Migration checklist

List of things to remember or todos for the content migration:

For each locale:

  • promotion pages:
    • before import, generate a promotion list for conversion to banner
    • copy all promotions docx
    • lower case folder names and filenames
  • author pages:
    • copy all
    • convert all to docx
  • topic pages:
    • copy all
    • copy taxonomy.xlsx
    • transform - add "article feed" block tag config
  • gnav
    • copy / paste existing HTML gnav into Word gnav
  • footer
    • copy / paste existing HTML footer into Word footer
  • articles
    • copy (overwrite .docx and remove .md) imported articles from temp sharepoint to theblog sharepoint
  • manually sync index pages with latest content

Batch load query-index

In the current implementation, we load the full query-index.json. The EN site contains 13k articles, the file is huge (time to download and time to parse). We should load batch of 1000 articles.

@davidnuescheler said he will take care of the implementation.

[Content] Pre-fill content in S3

Rough idea:

  • modify the edge dict for adobe/blog to use adobe/theblog contentbus id - i.e. adobe/blog uses a temporary sharepoint but the final contentbus id
  • preview / publish all content via adobe/blog - i.e. fill production S3

for the go-live:

  • change the fstab of adobe/blog to point to the adobe/theblog sharepoint (theblog Site)
  • switch the blog.adobe.com edge DNS to point to adobe/blog - production ready and live
  • behind the scene, update sharepoint, i.e. replace old content by migrated content

cc @tripodsan

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.