adobe / aem-cloud-migration Goto Github PK

Expected Behaviour

Running the jar on the maven archetype 22 should not cause any errors.

Actual Behaviour

Running the jar on the maven archetype 22 causes this error:
java.lang.NullPointerException at com.adobe.skyline.migration.parser.CustomerProjectLoader.isContentPackage(CustomerProjectLoader.java:96)

Fix (which I'm not able to push)

in CustomerProjectLoader.isContentPackage() replace

        String packaging = moduleXml.getElementsByTagName(MigrationConstants.PACKAGING_TAG_NAME).item(0).getTextContent();
        return packaging.equals(MigrationConstants.CONTENT_PACKAGE_PACKAGING);

with:

        NodeList packagingTags = moduleXml.getElementsByTagName(MigrationConstants.PACKAGING_TAG_NAME);
        if (packagingTags.getLength() > 0) {
            String packaging = packagingTags.item(0).getTextContent();
            return packaging.equals(MigrationConstants.CONTENT_PACKAGE_PACKAGING);
        }
        return false;

Expected Behaviour

Custom code in AEMaaCS should be able to make use of AssetSetLastModifiedProcess and DamMetadataWritebackWorkflowCompleted process step in their code base. As they are used in Writeback workflow of AEMaaCS and supported, hence should not be part of UNNECESSARY process list.

Actual Behaviour

Code with AssetSetLastModifiedProcess and DamMetadataWritebackWorkflowCompleted process step are reported as BLOCKER bug in code scan as they are marked as UNNECESSARY.

Reproduce Scenario (including but not limited to)

Steps to Reproduce

Platform and Version

Sample Code that illustrates the problem

Logs taken while reproducing problem

Expected Behaviour

Expecting workflow artifacts in legacy paths (like /etc/workflow/models/dam/update_asset) to be migrated to paths expected by AEM as a Cloud Service (/conf/global/settings/workflow)

Actual Behaviour

When workflow artifacts in a legacy tree (/etc/workflow) are updated by the tool, they are updated in place and not migrated to /conf/global/settings/workflow

Reproduce Scenario (including but not limited to)

Steps to Reproduce

Platform and Version

Using version 0.2.4

Sample Code that illustrates the problem

Logs taken while reproducing problem