Comments (2)
Applying an offset has mostly resolved this issue as described. However, there's a new issue that occurs when continuing after game parsing has completed.
The expected behaviour is that once we encounter a game over event, we kill parsing of the current game and return to our main loop. This is supposed to trigger a pause until noon on the following day, at which point we're supposed to determine whether there is a game on that day (if there is, we'll wait until the start time then parse; if there's not, we'll wait until noon on the following day).
Instead, the application indicates that there is no game regardless of whether there actually is one or not. If we simply restart the application, it correctly identifies that there is a game that day. This seems to indicate that we may not be checking the correct day during such continuations. More investigation is required here.
from nhl-bot.
I think this might fix it. Need to wait for a game day to test this though.
from nhl-bot.
Related Issues (17)
- Remove time-based checking from the record filter HOT 1
- Add GitHub workflow HOT 1
- Mention any existing penalties in penalty event tweets HOT 2
- Mention if a goal is powerplay or shorthanded when tweeting goal event HOT 1
- Mention the reason for the challenge during a coach's challenge tweet HOT 1
- Break dependency between printer and tweet classes
- Handle line score events
- Penalty description is sometimes just the severity
- Tweet all attempts during a shootout HOT 1
- The bot misses a day when a game ends after midnight EST
- The shootout complete event is unhandled HOT 1
- Shootout goals are registering as goalscorer changes HOT 1
- Neutral site games have the wrong arena listed HOT 1
- Use `diffPatch` to reduce response data size
- Handle updates to goal events HOT 1
- Not handling all possible game events HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nhl-bot.