Code Monkey home page Code Monkey logo

pandora's People

Contributors

addstar avatar addstarbot avatar alchemistmatt avatar archmohaa avatar dependabot-preview[bot] avatar narimm avatar razz0991 avatar schmoller avatar

Watchers

avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar

Forkers

chancesd miniworks18

pandora's Issues

Fix Give error 

org.bukkit.command.CommandException: Unhandled exception executing command 'give' in plugin Pandora v1.0.6-SNAPSHOT-102
        at org.bukkit.command.PluginCommand.execute(PluginCommand.java:46) ~[patched_1.13.2.jar:git-Paper-481]
        at org.bukkit.command.SimpleCommandMap.dispatch(SimpleCommandMap.java:149) ~[patched_1.13.2.jar:git-Paper-481]
        at org.bukkit.craftbukkit.v1_13_R2.CraftServer.dispatchCommand(CraftServer.java:732) ~[patched_1.13.2.jar:git-Paper-481]
        at net.minecraft.server.v1_13_R2.PlayerConnection.handleCommand(PlayerConnection.java:1792) ~[patched_1.13.2.jar:git-Paper-481]
        at net.minecraft.server.v1_13_R2.PlayerConnection.a(PlayerConnection.java:1595) ~[patched_1.13.2.jar:git-Paper-481]
        at net.minecraft.server.v1_13_R2.PacketPlayInChat.a(PacketPlayInChat.java:45) ~[patched_1.13.2.jar:git-Paper-481]
        at net.minecraft.server.v1_13_R2.PacketPlayInChat.a(PacketPlayInChat.java:5) ~[patched_1.13.2.jar:git-Paper-481]
        at net.minecraft.server.v1_13_R2.PlayerConnectionUtils.lambda$ensureMainThread$0(PlayerConnectionUtils.java:12) ~[patched_1.13.2.jar:git-Paper-481]
        at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) ~[?:1.8.0_191]
        at java.util.concurrent.FutureTask.run(FutureTask.java:266) ~[?:1.8.0_191]
        at net.minecraft.server.v1_13_R2.SystemUtils.a(SystemUtils.java:109) ~[patched_1.13.2.jar:git-Paper-481]
        at net.minecraft.server.v1_13_R2.MinecraftServer.b(MinecraftServer.java:1016) ~[patched_1.13.2.jar:git-Paper-481]
        at net.minecraft.server.v1_13_R2.DedicatedServer.b(DedicatedServer.java:439) ~[patched_1.13.2.jar:git-Paper-481]
        at net.minecraft.server.v1_13_R2.MinecraftServer.a(MinecraftServer.java:943) ~[patched_1.13.2.jar:git-Paper-481]
        at net.minecraft.server.v1_13_R2.MinecraftServer.run(MinecraftServer.java:841) ~[patched_1.13.2.jar:git-Paper-481]
        at java.lang.Thread.run(Thread.java:748) [?:1.8.0_191]
Caused by: net.minecraft.server.v1_13_R2.ResourceKeyInvalidException: Non [a-z0-9/._-] character in path of location: minecraft:potionRegeneration
        at net.minecraft.server.v1_13_R2.MinecraftKey.<init>(SourceFile:38) ~[patched_1.13.2.jar:git-Paper-481]
        at net.minecraft.server.v1_13_R2.MinecraftKey.<init>(SourceFile:43) ~[patched_1.13.2.jar:git-Paper-481]
        at au.com.addstar.monolith.lookup.Lookup.findByMinecraftName(Lookup.java:115) ~[?:?]
        at au.com.addstar.pandora.Utilities.getItem(Utilities.java:253) ~[?:?]
        at au.com.addstar.pandora.modules.ItemGiving.onGive(ItemGiving.java:103) ~[?:?]
        at au.com.addstar.pandora.modules.ItemGiving.onCommand(ItemGiving.java:254) ~[?:?]
        at org.bukkit.command.PluginCommand.execute(PluginCommand.java:44) ~[patched_1.13.2.jar:git-Paper-481]
        ... 15 more```

Dependabot couldn't authenticate with https://hub.spigotmc.org/nexus/content/groups/public

Dependabot couldn't authenticate with https://hub.spigotmc.org/nexus/content/groups/public.

Dependabot tried to authenticate with the details you previously provided, but authentication failed. If they are no longer valid you will need to provide Dependabot with new credentials.

You can provide authentication details in your Dependabot dashboard by clicking into the account menu (in the top right) and selecting 'Config variables'.

You can mention @dependabot in the comments below to contact the Dependabot team.

Exception from Sparklers 

java.lang.IllegalArgumentException: Particle REDSTONE requires data, null provided
        at com.google.common.base.Preconditions.checkArgument(Preconditions.java:191) ~[patched_1.14.4.jar:git-Paper-210]
        at org.bukkit.craftbukkit.v1_14_R1.CraftParticle.toNMS(CraftParticle.java:132) ~[patched_1.14.4.jar:git-Paper-210]
        at org.bukkit.craftbukkit.v1_14_R1.CraftWorld.spawnParticle(CraftWorld.java:2315) ~[patched_1.14.4.jar:git-Paper-210]
        at org.bukkit.craftbukkit.v1_14_R1.CraftWorld.spawnParticle(CraftWorld.java:2305) ~[patched_1.14.4.jar:git-Paper-210]
        at org.bukkit.craftbukkit.v1_14_R1.CraftWorld.spawnParticle(CraftWorld.java:2294) ~[patched_1.14.4.jar:git-Paper-210]
        at org.bukkit.craftbukkit.v1_14_R1.CraftWorld.spawnParticle(CraftWorld.java:2284) ~[patched_1.14.4.jar:git-Paper-210]
        at org.bukkit.craftbukkit.v1_14_R1.CraftWorld.spawnParticle(CraftWorld.java:2279) ~[patched_1.14.4.jar:git-Paper-210]
        at au.com.addstar.pandora.modules.Sparklers.doSparklers(Sparklers.java:140) ~[?:?]
        at org.bukkit.craftbukkit.v1_14_R1.scheduler.CraftTask.run(CraftTask.java:84) ~[patched_1.14.4.jar:git-Paper-210]
        at org.bukkit.craftbukkit.v1_14_R1.scheduler.CraftScheduler.mainThreadHeartbeat(CraftScheduler.java:452) ~[patched_1.14.4.jar:git-Paper-210]
        at net.minecraft.server.v1_14_R1.MinecraftServer.b(MinecraftServer.java:1171) ~[patched_1.14.4.jar:git-Paper-210]
        at net.minecraft.server.v1_14_R1.DedicatedServer.b(DedicatedServer.java:417) ~[patched_1.14.4.jar:git-Paper-210]
        at net.minecraft.server.v1_14_R1.MinecraftServer.a(MinecraftServer.java:1098) ~[patched_1.14.4.jar:git-Paper-210]
        at net.minecraft.server.v1_14_R1.MinecraftServer.run(MinecraftServer.java:925) ~[patched_1.14.4.jar:git-Paper-210]
        at java.lang.Thread.run(Thread.java:748) [?:1.8.0_191]```

SignLogger module broken

I tried the latest version (build 26) and looks like the SignLogger module is broken:

[15:53:56] [Server thread/WARN]: java.lang.NullPointerException
[15:53:56] [Server thread/WARN]:        at au.com.addstar.pandora.modules.SignLogger.onEnable(SignLogger.java:59)
[15:53:56] [Server thread/WARN]:        at au.com.addstar.pandora.MasterPlugin.createModule(MasterPlugin.java:343)
[15:53:56] [Server thread/WARN]:        at au.com.addstar.pandora.MasterPlugin.loadModule(MasterPlugin.java:285)
[15:53:56] [Server thread/WARN]:        at au.com.addstar.pandora.MasterPlugin.loadModules(MasterPlugin.java:257)
[15:53:56] [Server thread/WARN]:        at au.com.addstar.pandora.MasterPlugin.onEnable(MasterPlugin.java:102)
[15:53:56] [Server thread/WARN]:        at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:264)
[15:53:56] [Server thread/WARN]:        at org.bukkit.plugin.java.JavaPluginLoader.enablePlugin(JavaPluginLoader.java:316)
[15:53:56] [Server thread/WARN]:        at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:405)
[15:53:56] [Server thread/WARN]:        at org.bukkit.craftbukkit.v1_12_R1.CraftServer.enablePlugin(CraftServer.java:395)
[15:53:56] [Server thread/WARN]:        at org.bukkit.craftbukkit.v1_12_R1.CraftServer.enablePlugins(CraftServer.java:344)
[15:53:56] [Server thread/WARN]:        at net.minecraft.server.v1_12_R1.MinecraftServer.t(MinecraftServer.java:442)
[15:53:56] [Server thread/WARN]:        at net.minecraft.server.v1_12_R1.MinecraftServer.l(MinecraftServer.java:403)
[15:53:56] [Server thread/WARN]:        at net.minecraft.server.v1_12_R1.MinecraftServer.a(MinecraftServer.java:341)
[15:53:56] [Server thread/WARN]:        at net.minecraft.server.v1_12_R1.DedicatedServer.init(DedicatedServer.java:292)
[15:53:56] [Server thread/WARN]:        at net.minecraft.server.v1_12_R1.MinecraftServer.run(MinecraftServer.java:616)
[15:53:56] [Server thread/WARN]:        at java.lang.Thread.run(Thread.java:748)

Autosaver is broken in current build

After enabling Autosaver, this is happening now on the latest paper builds. I thought it was working previously when I tested it so maybe it was a Paper change?

21:36:40 [WARN]: Plugin Pandora v1.0.7-SNAPSHOT-128 generated an exception while executing task 15075
java.lang.IllegalStateException: WorldSaveEvent may only be triggered synchronously.
        at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:524) ~[patched_1.14.2.jar:git-Paper-68]
        at net.minecraft.server.v1_14_R1.WorldServer.save(WorldServer.java:758) ~[patched_1.14.2.jar:git-Paper-68]
        at org.bukkit.craftbukkit.v1_14_R1.CraftWorld.save(CraftWorld.java:1160) ~[patched_1.14.2.jar:git-Paper-68]
        at au.com.addstar.pandora.modules.autosave.RegionFileFlusher$SavingTask.run(RegionFileFlusher.java:53) ~[?:?]
        at org.bukkit.craftbukkit.v1_14_R1.scheduler.CraftTask.run(CraftTask.java:84) ~[patched_1.14.2.jar:git-Paper-68]
        at org.bukkit.craftbukkit.v1_14_R1.scheduler.CraftAsyncTask.run(CraftAsyncTask.java:54) ~[patched_1.14.2.jar:git-Paper-68]
        at com.destroystokyo.paper.ServerSchedulerReportingWrapper.run(ServerSchedulerReportingWrapper.java:22) ~[patched_1.14.2.jar:git-Paper-68]
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) [?:1.8.0_191]
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) [?:1.8.0_191]
        at java.lang.Thread.run(Thread.java:748) [?:1.8.0_191]

Doing "/tpclaim" with multiple claims generates exception

When typing /tpclaim when you have multiple claims, the below stack occurs.
In game, the attached pic is displayed.
tpclaim
(with just a single claim, it teleports you to the claim)

2020-01-24 21:53:42 [Server thread/INFO]: _adnap_ issued server command: /tpclaim 2020-01-24 21:53:42 [Server thread/ERROR]: null org.bukkit.command.CommandException: Unhandled exception executing command 'tpclaim' in plugin Pandora v1.15.1-SNAPSHOT-155 at org.bukkit.command.PluginCommand.execute(PluginCommand.java:47) ~[patched_1.15.2.jar:git-Paper-65] at org.bukkit.command.SimpleCommandMap.dispatch(SimpleCommandMap.java:159) ~[patched_1.15.2.jar:git-Paper-65] at org.bukkit.craftbukkit.v1_15_R1.CraftServer.dispatchCommand(CraftServer.java:740) ~[patched_1.15.2.jar:git-Paper-65] at net.minecraft.server.v1_15_R1.PlayerConnection.handleCommand(PlayerConnection.java:1820) ~[patched_1.15.2.jar:git-Paper-65] at net.minecraft.server.v1_15_R1.PlayerConnection.a(PlayerConnection.java:1628) ~[patched_1.15.2.jar:git-Paper-65] at net.minecraft.server.v1_15_R1.PacketPlayInChat.a(PacketPlayInChat.java:47) ~[patched_1.15.2.jar:git-Paper-65] at net.minecraft.server.v1_15_R1.PacketPlayInChat.a(PacketPlayInChat.java:5) ~[patched_1.15.2.jar:git-Paper-65] at net.minecraft.server.v1_15_R1.PlayerConnectionUtils.lambda$ensureMainThread$0(PlayerConnectionUtils.java:23) ~[patched_1.15.2.jar:git-Paper-65] at net.minecraft.server.v1_15_R1.TickTask.run(SourceFile:18) ~[patched_1.15.2.jar:git-Paper-65] at net.minecraft.server.v1_15_R1.IAsyncTaskHandler.executeTask(IAsyncTaskHandler.java:136) ~[patched_1.15.2.jar:git-Paper-65] at net.minecraft.server.v1_15_R1.IAsyncTaskHandlerReentrant.executeTask(SourceFile:23) ~[patched_1.15.2.jar:git-Paper-65] at net.minecraft.server.v1_15_R1.IAsyncTaskHandler.executeNext(IAsyncTaskHandler.java:109) ~[patched_1.15.2.jar:git-Paper-65] at net.minecraft.server.v1_15_R1.MinecraftServer.ba(MinecraftServer.java:1038) ~[patched_1.15.2.jar:git-Paper-65] at net.minecraft.server.v1_15_R1.MinecraftServer.executeNext(MinecraftServer.java:1031) ~[patched_1.15.2.jar:git-Paper-65] at net.minecraft.server.v1_15_R1.IAsyncTaskHandler.awaitTasks(IAsyncTaskHandler.java:119) ~[patched_1.15.2.jar:git-Paper-65] at net.minecraft.server.v1_15_R1.MinecraftServer.sleepForTick(MinecraftServer.java:1015) ~[patched_1.15.2.jar:git-Paper-65] at net.minecraft.server.v1_15_R1.MinecraftServer.run(MinecraftServer.java:938) ~[patched_1.15.2.jar:git-Paper-65] at java.lang.Thread.run(Thread.java:748) [?:1.8.0_191] Caused by: java.lang.NullPointerException at au.com.addstar.pandora.modules.gp.GPClaimData.getCreationdate(GPClaimData.java:32) ~[?:?] at au.com.addstar.pandora.modules.TpClaim.displayClaims(TpClaim.java:421) ~[?:?] at au.com.addstar.pandora.modules.TpClaim.onTPClaim(TpClaim.java:274) ~[?:?] at au.com.addstar.pandora.modules.TpClaim.onCommand(TpClaim.java:64) ~[?:?] at org.bukkit.command.PluginCommand.execute(PluginCommand.java:45) ~[patched_1.15.2.jar:git-Paper-65] ... 17 more

Liskov Principle

AngryPigmen

Pandora/src/au/com/addstar/pandora/modules/AngryPigmen.java

Line 19 in 752dc74

public void onEnable() {

We can see there's probably a violation of the Liskov Principle in this class, because the methods onEnable, onDisable and setPandoraInstance haven't been implemented. This means that objects from Module type can't be substituted by this class due to the lack of the implementation of these behaviours.

You could delete the implementation of the Module interface because the AngryPigmen doesn't implement the interface methods, and only leave the Listener implementation.

ItemGiving
https://github.com/AddstarMC/Pandora/blob/master/src/au/com/addstar/pandora/modules/ItemGiving.java
We can see here's also a probably violation of this principle. It's the same from the case above. But also the onTabComplete method is not implemented, so it's probably wrongly implemented.

(Recomendation made for educational purposes)

Interface Segregation Principle

Hi!, I'm computer science student, I'm learning about SOLID, and we have the job to find some possible violation of principles in git repositories, I think I have found some, In:
BeaconFix
https://github.com/AddstarMC/Pandora/blob/master/src/au/com/addstar/pandora/modules/BeaconFix.java
ItemGiving
https://github.com/AddstarMC/Pandora/blob/master/src/au/com/addstar/pandora/modules/ItemGiving.java
AntiPortalEntityTravel
https://github.com/AddstarMC/Pandora/blob/master/src/au/com/addstar/pandora/modules/AntiPortalEntityTravel.java

In BeaconFix you implement the interface PacketListener, that means that you have to implements the methods that come with it, in addition we know If I have already an interface with responsibilities, and the implementor doesn't need all these stuff, so you need to break these methods and regroup them into relational behavior.
In ItemGiving and AntiportalEntityTravel I watched the same for module with onEnable() and onDisable() methods.

Let me know if I'm wrong.
Have a good day.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.