Code Monkey home page Code Monkey logo

chrome-tabs's Introduction

chrome-tabs's People

Contributors

adamschwartz avatar alanshaw avatar amovah avatar brrd avatar epicfaace avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

chrome-tabs's Issues

Transfrom attribute

What's the use for the transfrom attribute? I thought it was a typo (as my tslint pointed out) and so renamed it to transform, which had no effect on Chrome (but firefox accepts it, which led to some debugging).

It doesn't seem to be a proper HTML attribute as per spec, and leaving it out doesn't seem to have any effect either

<svg version="1.1" xmlns="http://www.w3.org/2000/svg"><defs><symbol id="topleft" viewBox="0 0 214 29" ><path d="M14.3 0.1L214 0.1 214 29 0 29C0 29 12.2 2.6 13.2 1.1 14.3-0.4 14.3 0.1 14.3 0.1Z"/></symbol><symbol id="topright" viewBox="0 0 214 29"><use xlink:href="#topleft"/></symbol><clipPath id="crop"><rect class="mask" width="100%" height="100%" x="0"/></clipPath></defs><svg width="50%" height="100%" transfrom="scale(-1, 1)"><use xlink:href="#topleft" width="214" height="29" class="chrome-tab-background"/><use xlink:href="#topleft" width="214" height="29" class="chrome-tab-shadow"/></svg><g transform="scale(-1, 1)"><svg width="50%" height="100%" x="-100%" y="0"><use xlink:href="#topright" width="214" height="29" class="chrome-tab-background"/><use xlink:href="#topright" width="214" height="29" class="chrome-tab-shadow"/></svg></g></svg>

Issues with AMD

There are lot of issues while calling the library using RequireJS style AMD.

I have created a pull request which fixes this by using the UMD pattern.

setTabCloseEventListener fails if tab does not use close button.

Our application has one permanent tab, the home tab if you will, and it does not require the close button on it. You can see the error in the console when the page opens. Simply leave out the line in your html that says:

<div class="chrome-tab-close"></div>

I resolved this as follows:

setTabCloseEventListener(tabEl) {
    if (tabEl.querySelector('.chrome-tab-close') != null) {
        tabEl.querySelector('.chrome-tab-close').addEventListener('click', _ => this.removeTab(tabEl))
    }
}

setAttribute value not triggering

hi, I am trying to integrate ui tour guide in chrome-tabs. for that, I tried with a package named 'ngx-joyride' which required an attribute name called "joyrideStep = 'name'".so while initing chrome tabs for all the chrome elements I manually append an attribute element.setAttributeNS(null,"joyrideStep", tab_id) . while consoling chrome elements, attribute value updated but tour guide not showing in any of the chrome tabs. I also tried with a different tour package got the same result. not able to find where this issue is happening.

     all_left_panel_tabs.forEach((element) => {
         
         let tab_id = element.getAttribute('data-tab-id');
         element.setAttributeNS(null,"joyrideStep", tab_id);
         console.log(element);
       })
     this.joyrideService.startTour(
         { steps: ['backup','bookmarks','rvclean','workspace','settings','comments',],
           showCounter: true,
           themeColor: '#5a5e60'

         } // Your steps order
       )

"@angular/cli": "^6.2.9"
"chrome-tabs": "^5.4.0"     


thanks !.

Example

Hey, could you please give some example or instructions how to implement this?

Add remove animation

Potential solution: when removing tab, first sort it to the far right but make it inactive and opacity 0 (triggering the cascade animation), then actually remove it.

Tab contents positioning issue.

Hi there,

Thanks for the awesome work. I'm using this plugin to create multi window inside my website likely to create tabs with window content in chrome browser. I have created tabs and the are tab contents successfully but the tab contents are not positioning properly (ie) not started from starting position of the page.

Problem - 1:
The tab contents started from where the tabs are created as it is in plugin demo page.

Problem-2:
The tab contents not positioning properly, If I close the tab previous to the current tab or next to the current tab.

26975143-2e24b8d2-4d3c-11e7-8760-94d4ef4f2a1b

React-compatible version

I’ve received some inquiries about creating a React-compatible. This issue is here to track interest, and find an author/shepherd.

Moving tabs

When moving the right tab to the left, the previous left tab will move to the right. This is correct, but no animation.

Just a question

Hi, really cool what you've done!

I was wondering why using svg instead of just css for the tab shape? I'm not an expert in CSS, but I think it's accomplishable with CSS too. Anyhow, there's maybe no special reason for using svg, but just got curious about it.

Thanks!

Tabs depth and change style for multi tabs.

Firefox: v61.0.1
Chrome: v67

Just look around for errors and bugs and this time I find some more stuff for fix. Just look every time when open new tab and how the "style" change to Chrome tabs. The letters must hide and tabs must styled as triangle after x (number of tabs e.g. x = 40 or 50 tabs).

chrome-tabs:
chrome-tabs-issue-2

vs

Chrome:
origin-chrome-tabs

Must fix depth and style for tabs.
screenshot_2
screenshot_3

Chrome tab

https://github.com/adamschwartz/chrome-tabsHi im using your chrome tab extension in my application i get it from src-works im using minified version of the library i want to add some features to it could you give me the right source code i didn't find in your github account

      this.$chromeTabs = $('.chrome-tabs').chromeTabs({ allowDoubleClick: false});
      this.$chromeTabs._ = this.$chromeTabs.data('chromeTabs');
      this.$chromeTabs._.addTab({ url: 'http://akveo.com/ngx-admin/pages/forms/buttons', title: 'Dashboard', allowClose: false });

this is the sample usage

Events

I would really like a list of events/trigger. How to trigger something if tab is created, moved or closed...?

chrome-tabs background color bleeding through individual tabs

untitled

In the screenshot above (using Chrome as browser), I set...

.chrome-tabs {
    background: red;
}

...to emphasize the problem, and you may need to zoom in/resize the browser to reproduce the issue.

I was able to remove the bleeding vertical line by removing the inline width="50%" attribute in the "chrome-tab-geometry-right/left" <svg> HTML elements (or change it to something greater than 50%, but I think these width and height attributes can be removed entirely - their width and height percentages are already being set in the CSS?).

Not too sure about the bottom line.

Add the content window to each tab like chrome browser

Hi,
I like to add the mock-browser-content inside each tab created instead of having the mock-browser-content statically standing outside of chrome tabs created.
But styling issues happening when trying to add inside the tabs. It would be helpful if you add that functionality.

Chrome-Tab-Content Positioning

Hi there ,

Tab content set to the full width using,
$('.chrome-tab-content').width(document.documentElement.clientWidth);

but the tab content start from the left position 0 of corresponding parent element.

I tried to fix the position of the tab content starts from and take entire space to visible the current tab using,

if ($('.chrome-tab-current').offset().left !== 69) {
      var vleft = $('.chrome-tab-current').children().eq(4).children().offset().left;
      $('.chrome-tab-current').children().eq(4).children().css({ 'position': 'absolute', 'left': '-' + (vleft - 50) + 'px', 'top': '26px', 'z-index': '1' });
  } else {
           console.log('Offset left not matched.');
  }

Now the positioning issue solved by setting the positioning manually. But when closing the prev tabs, the position of sibling tabs went outside of left due to -posision applied to fix the full width.

I hope you understand. If Im not clear, pls check the image posted earlier.

Chrome tab content feature

Hi look after the chrome browser tabs. The content of the tab takes full width and other tab contents not visible. Also the contents not overlapping with another tab contents when close the tabs. Only the current tab or active tab contents only visible to the user.

I request you to enhance the plugin feature.

Tab Contenet Positioning

Hi there,

Thanks for the awesome work. The plugin is awesome but have minimal feature. If get into the development with your plugin lot more needed. At least basic feature should be there is appreciable.

I have found some features not there,

  1. Tab content not visible (May be width / height not set)
  2. After set width and height, the tab content just displaying the same size what we assigned to tab not taking full width. So all the tabs displaying the corresponding tab contents.
  3. If I close the previous tab the current and next tab contents not taking fulll width.

Pls see my work with your plugin, I'm facing this issues. I have modified as my need but still having the problem when closing the tabs.

I have created tabs and the are tab contents successfully but the tab contents are not positioning properly (ie) not started from starting position of the page.

Problem - 1:
The tab contents started from where the tabs are created as it is in plugin demo page.

Problem-2:
The tab contents not positioning properly, If I close the tab previous to the current tab or next to the current tab.

chrometab_issue

26975143-2e24b8d2-4d3c-11e7-8760-94d4ef4f2a1b

Thanks.

Does not work in IE

All functions like add, dark theme, remove background tabs and close icons doesn't show up
image

Chrome Tabs Stacked VERTICALLY?

I am looking for a chrome extension which allows me to automatically sort and group Chrome tabs...VERTICALLY. (not horizontally). I have just spent 10 hours trialing every tab organizer extension I could find, and none of them have this feature. for example, if I have 10 tabs open "domain1.com" it will nicely organize them into a vertical bucket, drop down etc, is that possible yet with Chrome? If you find something like this, can you message me on skype? SMARTCHOICEWEB

Sticky :hover effects on mobile

I noticed this with the tab hover opacity becoming active and "staying" active on a tab, but similar sticky behavior can be seen on the tab close button.

The easiest way to reproduce is to load up the demo as a mobile device, click once on the Google tab, then click and drag the Facebook tab, and the hover effect stays on the Google tab. Basically, do a solid click on one tab, and then a quick click and drag on another tab.

gif

Potentially encapsulate the hover styles in a CSS media query?
http://www.javascriptkit.com/dhtmltutors/sticky-hover-issue-solutions.shtml

Mobile support

Mobile click don't emit 'activeTabChange' and other events.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.