adamcin / nuromancy Goto Github PK

Instead of shipping around a bloated node_modules folder, maybe we can tighten up the whole app into a single minified js file for distribution.

Don't stop at npm test!

ibid

Give it another once-over, and all that.

The service should log errors and support tracing across services when deployed in Azure.

Add request case defined by GET /romannumeral?min={integer}&max={integer}

{integer} must be an integer value for both the min and max parameters. Both min and max must be provided. Min must be less than max. Both must be in the supported range 1-3999.

Respond with JSON object containing a conversions array, with one element per each integer member of the input range. Each element is the same form as the response from the existing resource defined by the ?query param:

{
  "conversions": [
    { "input": "1", "output": "I" },
    { "input": "2", "output": "II" },
    { "input": "3", "output": "III" }
  ]
}

I feel like the actual Usage of the service is important to include, in addition to the building and the distribution and all that.

Add a Links section, then add a link to Wikipedia: Roman numerals

• Remove reference to rxjs after removal of dependency by #10
• Specify host port binding in docker run instructions

• Use Promise.all() in the first test in convert.test.js
• Use null coalesce operator (?? {}) in first line of romanNumeral handler in handlers.js

Endpoint must accept a query QS param representing a base-10 integer value in the range of 1-3999.

Response message containing a successful conversion should be a JSON object of the form:

{
  "input": "1",
  "output": "I"
}

When an illegal request was received, the response status will be a 400, and the response message body will be a JSON object of the form:

{
  "error": "<reason>"
}

Status Codes:

• 200: Success
• 400: Client specified invalid parameters

Configure codecov.org for this repo, with Github Actions and Jest support:

Codecov Example

Instead of leaving the original helloworld handler for the root route, which is rather useless, let's replace it with a handler that serves a string describing a pair of html forms to make it easier to navigate from / to either of the two /romannumeral query types.

Plan to use forkJoin function

Stick to vanilla js