adamcaviness / vs-code-theme-monokai-dark-soda Goto Github PK

In the default monokai theme, there is semantic highlighting for things like c++ classes, however these appear to be missing in this theme.
Would it be possible to take the preexisting semantic highlighting from the default monokai theme and put it into this theme?
I believe that the c++ sementic highlighting for monokai is in the c/c++ themes extension

Hi,

We are very disappointed that the theme was changed! It has upset all the color and highlights we are so used to. The changes could have been created under a new extension and not altered the existing. This has upset many of us. In fact many of us started to suspect virus infection and started to clean the workstations and reinstall the all the extensions.

Fortunately, one of them did the whole thing and found the problems still persisted. Only then we realized the existing themes have been updated. Sad to say, our feedback is that we do not like the newer version. Is there any way of reverting to the older version?

The bade party is that we found that the syntax checking has also gone. For example in php, when i type in a variable that does exist, i get a sqiggly underline to show that the variable does not exist. Now it does not work??? This has happen after vs code loaded the latest version of this theme.

I have been using this theme for some time in VS Code and would love to apply it to Slack. Wondering if there is any interest or if I am the only one.

Hi @AdamCaviness, thanks for the great theme. This one is my ride-or-die for years now.

Would you be open to publishing the extension to the Open VSX Registry so that it is available to things like GitPod and VS Codium? A while ago I was asked to publish an extension there by a community member and when I finally got around to it 😅, it was very quick and easy.

You claim a namespace, which is your publisher name via a PR. Then click a couple times in your user account to create a publisher token. Lastly, use their CLI to publish your extension.

Anyway, thanks again for the theme. Peace! ✌️

Firstly, thanks so much for your theme - it's really nice :)

I've been using it with the following little improvement to highlight JS string interpolation:

// in settings.json
"editor.tokenColorCustomizations": {
  "textMateRules": [
    {
      "scope": "meta.template.expression",
      "settings": {
        "foreground": "#F8F8F2"
      }
    },
    {
     "scope": "punctuation.definition.template-expression.begin, punctuation.definition.template-expression.end",
     "settings": {
       "foreground": "#F92672"
     }
    },
  ]
},

Before:

After:

Would you be open to accepting a PR adding this change? Thanks!

The highlight colour in Monokai Dark Soda is the same colour as the background of non-workbench panels, so highlights cannot be seen. This appears to have happened when VS Code switched to using the Monaco editor for settings search, source control and more.

Default theme:

Monokai Dark Soda:

For reference, this is the highlighting colour when used in a workbench window:

I think, either:

1. Fix foreground and highlight colours in non-workbench text editors
2. Don't apply colour theme to non-workbench text editors (this might be a VS Code change)

Work around

Add the below lines to your settings.json. It changes the input box background colour to the same as the workbench background, so highlights are visible.

    "workbench.colorCustomizations": {
        "[Monokai Dark Soda]": {
            "input.background": "#242424"
        }
    }

Hi there and first off, thanks for supporting this theme over the years!

I'm sorry if this comes off as a bit of a nitpick, however, with the recent update, I've noticed some interface and theme colour changes that seem like a significant departure from the previous overall theme. I think the main interface changes are already mentioned in #15, however, I also wanted to surface contrast changes specifically.

To be clear, I am observing that the IDE background has changed from #242424 to #26282c, the IDE text has changed from #e3e3df to #d3d5d8, and the Python Jupyter Notebook background has changed from #242424 to #2c313a (this list is non-exhaustive, other changes were observed). Overall, these changes have resulted in worse contrast across the board. Using the contrast checker on coolors.co, I am observing a 2-6 point regression for these new foreground/background pairings.

I would like to ask if this is a new direction for this theme or potentially something unintentional? Would it be possible to realign some of the main pairings with the stated colour scheme in the README?

FYI, I am using the latest editions of VSCode (1.77.1) on macOS 13 (MacBook Pro 16, M1).

When I open a Jupyter Notebook .ipynb file, the color theme doesn't get applied like it does with a normal .py file.

This is my favorite color theme. Thanks!

Semantic highlighting is provided by the TypeScript language server and goes on top of the syntax highlighting based on TextMate grammars. The default syntax (TextMate) highlighter classifies many tokens as variables and these are now resolved into namespaces, classes, parameters, and so on.
Read more

Related to #5

There's a new feature Terminal Sticky Scroll transparency which I hope this feature can use

React Code up there BaseSelectData should be white and is white before
after update VSCode to February 2020 (version 1.43)
i got wrong color rendered

I had turn off all my extension only allow theme to work but still happened
and i had reinstall extension and downgrade still dont solve this QQ

any idea ? thx for helping

Hi there! Big fan of the theme.

With 1.1.0, it seems that the base theme is now Atom One Dark.

To my understanding, you've used Atom One Dark as a reference to add support for more tokens/scopes.
In the process, it seems that Atom One Dark colors are also now used for the rest of the interface.
I saw that you replied to a comment on 39bd882, however I'm not sure if this means that Atom One Dark will be the base theme going forward.