adam-thomas / imperial-painter Goto Github PK

Currently, CardListReload calls the import_cards management command using call_command, which seems off. A module to store the bulk of the importing code, which could then also be separately tested from the management command, would be a good refactor. Probably also a good opportunity to re-layout some of the code.

Rather than have to copy out a card multiple times in an Excel spreadsheet, let's add an optional quantity field/column that will cause Painter to display that number of the card.

Currently, printing requires some faff:

• The scaling needs to be set to 70% (this seems consistent, so maybe I just have to downsize the site, unless there's a way of forcing a default scaling value).
• 'Fit to page' works poorly since the cards aren't scaled vertically, hence the need to set to 70%. There may be a way around this.
• Without background colours turned on (they're usually off by default) the cards look way less good. Worth seeing if I can enable that by default.

An import is a bit useless without a way to use it!

• Add a management command to run the Excel import.
• Call that management command during make paint.

Just in case something messes up, the importer should check the layout of the imported Excel file and provide good error output if something fails.

This is also the place to add fallbacks for behaviour I want to allow.

Potential failure cases:

• Missing name or template headers - Throw an error.
• Missing card name - Throw an error.
• Missing template name - Throw an error.
• Empty rows - Ignore them. (tablib probably has that covered already.)

This will probably be done fully or partially as part of #5.

Some in-game entities might have two or more cards associated with them, such as Warmachine's double-sided unit cards with the full rules on the back. I can support that by allowing multiple entries (comma-separated?) in the Template column and rendering both, next to each other.

From #9:

• /?load=filename,filename2 - Refresh using the filenames supplied. (This can be a separate issue.)

Adding the ability to specify which filenames were being loaded from would be very useful. This way, you can avoid using the management command altogether if you like.

• Update to the latest version of Django (4.0.3 at time of writing).
• Switch to my modern-day code style (double quotes, extra newlines between functions/methods).
• Sanitise template names being used as CSS classes.
• Check printing behaviour on both Firefox and Chrome and ensure it's consistent.
• Document the use of em and CSS element sizing in general.
• Add (and document) a system for applying custom fonts and other dependencies instead of leaning on the ones in card_display.html.
• Allow alternate card importers to be plugged in in projects using Painter. Move import_laundry.py to the project it was intended for.
• Ensure consistent usage across the various projects using Painter.
• Start versioning changes.

Multiple worksheets for multiple card types (with potentially different header rows) seem useful, so let's add that.

Currently, it's a bit of a faff to get Painter up and running on a new machine. A compiled form that only required CSVs and custom templates - whether running locally via Python, or deployed somewhere online - would be much more useful.