FeatherS2 running 7.0.0, using the 7.0.0 libraries

>>> from adafruit_gc_iot_core import MQTT_API, Cloud_Core
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "adafruit_gc_iot_core.py", line 32, in <module>
  File "adafruit_jwt.py", line 32, in <module>
  File "adafruit_rsa/__init__.py", line 16, in <module>
  File "adafruit_rsa/key.py", line 27, in <module>
  File "adafruit_rsa/prime.py", line 13, in <module>
  File "adafruit_rsa/randnum.py", line 12, in <module>
  File "adafruit_rsa/transform.py", line 14, in <module>
  File "adafruit_binascii.py", line 57, in <module>
RuntimeError: maximum recursion depth exceeded
>>> 

There are missing type annotations for some functions in this library.

The typing module does not exist on CircuitPython devices so the import needs to be wrapped in try/except to catch the error for missing import. There is an example of how that is done here:

try:
    from typing import List, Tuple
except ImportError:
    pass

Once imported the typing annotations for the argument type(s), and return type(s) can be added to the function signature. Here is an example of a function that has had this done already:

def wrap_text_to_pixels(
    string: str, max_width: int, font=None, indent0: str = "", indent1: str = ""
) -> List[str]:

If you are new to Git or Github we have a guide about contributing to our projects here: https://learn.adafruit.com/contribute-to-circuitpython-with-git-and-github

There is also a guide that covers our CI utilities and how to run them locally to ensure they will pass in Github Actions here: https://learn.adafruit.com/creating-and-sharing-a-circuitpython-library/check-your-code In particular the pages: Sharing docs on ReadTheDocs and Check your code with pre-commit contain the tools to install and commands to run locally to run the checks.

If you are attempting to resolve this issue and need help, you can post a comment on this issue and tag both @FoamyGuy and @kattni or reach out to us on Discord: https://adafru.it/discord in the #circuitpython-dev channel.

The following locations are reported by mypy to be missing type annotations:

• adafruit_gc_iot_core.py:53
• adafruit_gc_iot_core.py:103
• adafruit_gc_iot_core.py:140
• adafruit_gc_iot_core.py:153
• adafruit_gc_iot_core.py:163
• adafruit_gc_iot_core.py:171
• adafruit_gc_iot_core.py:179
• adafruit_gc_iot_core.py:200
• adafruit_gc_iot_core.py:219
• adafruit_gc_iot_core.py:232
• adafruit_gc_iot_core.py:241
• adafruit_gc_iot_core.py:249
• adafruit_gc_iot_core.py:256
• adafruit_gc_iot_core.py:279
• adafruit_gc_iot_core.py:299
• adafruit_gc_iot_core.py:332

The Publish method (https://github.com/adafruit/Adafruit_CircuitPython_GC_IOT_Core/blob/master/adafruit_gc_iot_core.py#L269) in this library should reflect the Publish(mqtt_topic, data, qos) structure of the Adafruit IO and AWS IoT CircuitPython libraries.

Method: https://github.com/adafruit/Adafruit_CircuitPython_AdafruitIO/blob/master/adafruit_io/adafruit_io.py#L364

This library likely needs updates due to the adafruit_logging library upgrade. New use should be CPython compatible, and it may be worth allowing the CPython logging module to be imported if available.

Some common issues that are now present across libraries:

• Locations of classes have changed, and some may have been removed.
• PrintLogger no longer exists; instead, instance a Logger and add a StreamHandler instance with default arguments as the handler.

Similar to adafruit/Adafruit_CircuitPython_AdafruitIO#42

Relevant import here: https://github.com/adafruit/Adafruit_CircuitPython_GC_IOT_Core/blob/master/examples/gc_iot_core_simpletest.py#L10

the loop_forever() method is being deprecated on next planned release of adafruit_minimqtt library. Opening this issue as a reminder in accordance with this PR comment