actions-ecosystem / action-bump-semver Goto Github PK

What you want to add

Update to, at least, node16 in action.yml.

Why this is needed

When running a workflow with actions-ecosystem/action-bump-semver@v1:

Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: actions-ecosystem/action-bump-semver

What you want to add

Ability to pass —preid option to server

Why this is needed

Specify a prefixed

This is online with the server documentation

https://www.npmjs.com/package/semver

--preid <identifier>
        Identifier to be used to prefix premajor, preminor,
        prepatch or prerelease version increments.

I already have a patch for this

What happened

If I run this action, then I observe some newly created files in the .git/ directory have permissions of root.root.

What you expected to happen

Permissions end with user 'runner' and group 'docker', which is the default of github

This is likely because the using: 'node12' runs inside a docker container as the root user, and those permissions propagate outside the container as well.

When using other actions from https://github.com/actions-ecosystem it all works OK because everything runs as root inside docker and can write to the .git folder just fine.

When you try and run other steps that aren't in docker containers, it then breaks. For instance, if you run this github action, then do:
git fetch --depth=1

It'll complain about not having permission to write to files in the .git folder. If you look in there, some directories will have root.root as owner, others runner.docker.

Solution ideas: (not sure which is best/easiest/right answer)

• Run the script via the docker container (somehow) as non-root, not sure if that's possible to do on github easily.
• Just before this action completes, do: sudo chown -R $USER:$USER ./.git (probably the easiest fix)
• Mention in the docs that users should do the chown as a step themselves if they run into permissions issues

I might take a stab at fixing this in a PR real quick

When using actions-ecosystem/action-bump-semver@v1:

Warning: The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/