acquia / acquia-search-proxy Goto Github PK

If you define an "autocomplete" callback, docment how to test it

Modify that file to show the different operations, e.g. add, update, delete, and read (queries)

Currently the project root is the docroot, it would be great to put the index.php file in another directory named "docroot".

It would be great to define an index's connection through environment as opposed to requiring a configuration file and indexes.json file.

Step:

./bin/acquia-search-proxy indexes:auth CONF_DIR/indexes.json

Proposed fix:

Add some fake example values into the command output

Helps preserve the repository and not introduce code from specific examples

Add examples of how to debug.

Also, consider adding upstream support for debugging to PSolr (namely the SolrClient.php class that builds the Guzzle request).

This tool relies on acquia-cloud-sdk, which has a subpackage for search SDK. In composer.json:

"acquia/acquia-sdk-php-search": ">=0.10.0,<0.11.0",

The search SDK relies on the PSolr package, found here: https://packagist.org/packages/acquia/acquia-sdk-php-search

PSolr shows a reliance on guzzle/service https://packagist.org/packages/cpliakas/psolr, which has been deprecated: https://packagist.org/packages/guzzle/service

I found an acknowledgement of a Guzzle upgrade here: cpliakas/psolr#9. I have also found the most current package to be 6.2.3 from https://packagist.org/packages/guzzlehttp/guzzle (which appears to be the most recent, non-deprecated Guzzle). In lieu of a version 4/5 upgrade, I'm going to propose a version 6 upgrade in the issue.

I am leaving this here to track, as I would imagine if this upgrade happens, it would affect the code examples and possible usage of PSolr in this package.

http://silex.sensiolabs.org/doc/providers/service_controller.html

Currently version 0.7 of the SDK is required, at the time of this post 0.10 is the latest.

Should be "identifier".

Bad paths, docroot is in a directory inside of the project root, config is at the same level but not acknowledged in the example

The SDK has moved past the requirements, so we should appropriately bound the requirements.

require 'vendor/autoload.php';

When following the instructions, composer will load the vendor directory in the project root.

As such, this reference should be a directory up.

It's not clear if "%root-dir%" is a placeholder

It's not clear if we need to change the value for indexes.json if we build it as the instructions articulate (e.g. the default setting will persist)

It's not clear what acquia.search.proxy.identifier represents. Is this a SOLR core?

Example has:

$result = \PSolr\Request\Suggest::factory()
        ->setQuery($query)
        ->sendRequest($app['acquia.search.index'])
    ;

setQuery no longer is a function, need to update this.