acornjs / acorn-private-methods Goto Github PK

I've tried using this plugin directly and the stage3 plugin and both throw an error (SyntaxError: Unexpected token) for private getters and setters. I just have a simple example:

class MyClass {
  get #myMethod() {
    return 'hello';
  }
}

The error is thrown on the line of the getter declaration, right after the get keyword. Just to make sure I wasn't using it wrong, I cloned the repo and ran the tests and it looks like they're failing for the private getters and setters too. Has this feature been removed from the plugin?

Using npm run build, I see:

(!) Unresolved dependencies
https://rollupjs.org/guide/en/#warning-treating-module-as-external-dependency
acorn-private-class-elements (imported by index.js)

It looks like https://rollupjs.org/guide/en/#with-npm-packages can fix this. Is it okay for me to put up a patch that does this? Or would you rather acorn-private-class-elements be required at runtime?

@adrianheine it seems like the latest commit has not been released so far. I guess this could be done as a patch release?