Code Monkey home page Code Monkey logo

Comments (7)

aclindsa avatar aclindsa commented on July 20, 2024 1

Thanks for fixing this up for me and even providing an additional test case!

from ofxgo.

aclindsa avatar aclindsa commented on July 20, 2024

Interesting! Thanks for bringing this to my attention.

I think I would prefer to relax the validation rather than removing it completely (i.e. explicitly allow either "NONE" or "TYPE1", rather than allowing any possible value). Is this something you're willing and able to provide a patch for?

from ofxgo.

davidalpert avatar davidalpert commented on July 20, 2024

for sure! patch coming up.

from ofxgo.

davidalpert avatar davidalpert commented on July 20, 2024

please see PR #40

from ofxgo.

davidalpert avatar davidalpert commented on July 20, 2024

@aclindsa would it be possible to release a patch version with this fix in it? say 0.1.2?

the latest release appears to be 0.1.1 and does not yet contain the ability to parse SECURITY value of TYPE1.

from ofxgo.

aclindsa avatar aclindsa commented on July 20, 2024

@aclindsa would it be possible to release a patch version with this fix in it? say 0.1.2?

the latest release appears to be 0.1.1 and does not yet contain the ability to parse SECURITY value of TYPE1.

Absolutely, 0.1.2 is tagged now!

from ofxgo.

davidalpert avatar davidalpert commented on July 20, 2024

thank you so much! 👏

from ofxgo.

Related Issues (12)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.