Marshalled requests for OFX 102 should not include element end tags about ofxgo HOT 7 CLOSED

@JohnStarich Absolutely feel free to give it a shot!

from ofxgo.

Hah! SGML is a thorn in my side. For the full set of the elements which may be left un-closed with the SGML versions of OFX, see https://github.com/aclindsa/ofxgo/blob/master/leaf_elements.go.

As you've already found, I used a feature of Go's existing XML decoder for parsing SGML responses (though I had to modify it slightly). I don't see any reason my existing fork of the library couldn't be modified further to omit closing tags for the same list from above. I didn't make the similar modification for encoding requests mostly because it seemed like I was going to be able to get away with it, not because I have an issue with doing it.

I believe this modification should be acceptable for all SGML-based OFX versions (i.e. 1xx), and should not need to be USAA-specific.

from ofxgo.

Oh, excellent! I didn't see you had the complete list already 🎉

Sweet. Yeah, I thought that might've happened 👍 Sometimes it's best to just get things working first! 😉

Nice, ok. I'm not very familiar with the Go XML encoder, but I can give it a shot if you like?

from ofxgo.

To my surprise, this ended up being pretty easy! (unless I missed something 😨)
I've pushed a new PR up for your review in the xml repo.

I think the calling syntax in ofxgo would look super similar to how the decoder is set up today.

from ofxgo.

Thanks for the quick review/merge! 😄
I've put up a PR for the last piece, too #19

from ofxgo.

friendly poke 👉 @aclindsa

from ofxgo.

Thanks a bunch @aclindsa! 🎉

from ofxgo.