accurat / react-components Goto Github PK

Ideally the select would understand by itself if is overflowing the window, and move up without having to specify a prop. Some datepickers do this for example.

Originally posted by @marcofugaro in https://github.com/accurat/rct-webtraffic-frontend/pull/258

And also, would be useful to not have inline styles, so we can customize those!

Also, it seems the disabled prop is not working: it only changes appearance but the Toggle still works!

cc @aminalhazwani

It will allow us to do tree-shaking and to use index.ts at the root

Would be super cool to have 5 possible inputs to pass:

• width
• height
• default background color
• active background color
• toggle color

So that we can do easily this type of customization. The toggle size and its two positions (on/off) should then be dynamically calculated.

Nit on/off labels

Originally posted by @aminalhazwani in #49 (comment)

Another point: would be maybe useful to add a LabeledToggle too.

Originally posted by @caesarsol in #49 (comment)

In order to avoid the use of 'reset' property we were thinking about introduce a 'default' property that, if false, will assign a default style to the component or custom classes and style otherwise.

For consistency, we should disable the uncontrolled behaviour as already done with the Checkbox component

When having a very long list of values in a "single value" Select, it would be useful to scroll to the active value

Type 'Element[]' is missing the following properties from type 'ReactElement<any, string | ((props: any) => ReactElement<any, string | ... | (new (props: any) => Component<any, any, any>)>) | (new (props: any) => Component<any, any, any>)>': type, props, key

using v.0.4.1

Could probably be solved by changing the type to JSX.Element which should be more flexible ?

Seems to work fine on v0.3.7

E.g. export interface TextInputpropsType extends HTMLProps<HTMLInputElement>

Some attributes are missing on the TextInput.
In particular the pattern attribute, that us used to check the validity is missing.
Another useful attribute is autocomplete, used with off or none for security reason

Should be able to pass any key from InputPropTypes

FlexView returns an error if a child is true.

Is your feature request related to a problem? Please describe.

Would be great to have the possibility to trigger the mobile native UI for select

Describe the solution you'd like

Could be done by adding a new prop which renders the <select/> html tag instead of the custom element

Steps to reproduce

• Instancing a Select component with some props (such as childrenClassName) makes React warn with Unknown prop for <div> element, because it gets leaked to the div on line https://github.com/accurat/react-components/blob/master/src/components/Select/index.tsx#L104.

Solution is to add all the props on line https://github.com/accurat/react-components/blob/master/src/components/Select/index.tsx#L51.

Actual behavior

Warning.

Expected behavior

No warnings.

In Button handleClick props is used, in Radio onClick. I think it's better to align to the standard onClick props name so you don't have to use for these components the handleClick and for standard DOM elements onClick.