Code Monkey home page Code Monkey logo

branch-dictator's People

Contributors

spencerkaiser avatar

Stargazers

avatar

Watchers

avatar

Forkers

lgtm-migrator

branch-dictator's Issues

feat(middleware): Utilize utilize @octokit/webhooks

Pre-requisites:

Feature Description

It would be super convenient to use @octokit/webhooks's middleware functionality, unfortunately the index.d.ts file seems to be missing some exports for the standalone functionality. Without creating our own declaration file (which would be brittle), custom implementation seems like the best approach.

Additional Details

hold: I opened an issue against the project, so after that is fixed this can be implemented

bug(private repo): Private repo creation results in a 500

Pre-requisites:

Description

Creating a private repo results in a 500

Expected Behavior

The app should skip the call to the GitHub api as it will always fail

Actual Behavior

It calls the api, fails, and throws a 500

Repro Steps

Create a private repo

Other Information

bug(branchless repo): Repo creation without branch results in 500

Pre-requisites:

Description

Creating a repo without a README, license, and gitignore results in a branchless repo which in turn results in a 500 error due to an api 404 (branch doesn't exist)

Expected Behavior

The app should know not to try to hit the API

Actual Behavior

A 404 -> 500

Repro Steps

Create a repo without creating an initial commit

Other Information

I'd argue that this is a bug on the GitHub side of things... if a repo doesn't have a branch, the default_branch should be null. I'm not actually sure if a repo in GitHub can have a branch. If the repo truly does have a branch, specifying the latest commit (or even updating pushed_at to have a value on repo creation) would give the recipient of the event a little more context.

bug(auth failure): Webhook events throw 401

Pre-requisites:

Description

Events are currently failing with a 401

Expected Behavior

They'd pass with a 200

Actual Behavior

401

Repro Steps

Trigger a webhook event

Other Information

Turns out the x-hub-signature actually has sha1= prepended to it; the validation logic needs to be updated to add that.

feat(lgtm): Enable lgtm

Pre-requisites:

Feature Description

This project should utilize lgtm for code analysis and PRs should be dependent on successful passing of their tests

Additional Details

feature(Heroku env variables): Store env variables in GitHub and use in the Heroku Action

Pre-requisites:

Feature Description

Ideally all environment variables used in Heroku would exist in the repo's secrets and used on deploy to maintain 100% uptime and prevent the need for manually setting environment variables.

Additional Details

Hold: This issue against the Heroku Deploy Action must be implemented before this issue can be addressed.

feat(org even listener): Implement event listener for

Pre-requisites:

Feature Description

The app should include a event listener for the repository event. The listener should validate the event and use the webhook secret to ensure the authenticity of the request. If the request is unauthorized, return an appropriate status code, otherwise return a 200.

Additional Details

The webhook's actual implementation will be covered by another issue.

feat(GitHub Actions): Create CI/CD actions

Pre-requisites:

Feature Description

The project should have Actions to support CI and CD with the following features:

CI (required for PR merge)

  • Build the app
  • Run test suite
  • Run linter
  • Run prettier

Status should be reported back and a badge should display said status in the README

CD (on merge to master)

  • Deploy the app to Heroku

Additional Details

feature(private repos): Enable private repo branch protection

Pre-requisites:

Feature Description

The GitHub API requires users to have a Pro account or for the repo privacy to be public:

Upgrade to GitHub Pro or make this repository public to enable this feature. - Upgrade to GitHub Pro or make this repository public to enable this feature.

If the user has a Pro account, they should be able to set an environment variable to allow for private repo branch protection and override the existing check.

Additional Details

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.