In the end, we should decide whether we use relative imports in the relevant places (e.g. when we are in atomate/abinit/..., just do something like from .fireworks import scf_fw).

Pros: more concise
Cons: less clear => sometimes difficult to know from where something is imported

Following the discussion about pseudopotentials, I'm opening this issue to keep track of suggestions, different options, etc.

Basically, the pseudos will be specified in the abinit input file with pseudos and pp_dirpath, starting with abinit v9. Compatibility with v8 and the .files file is not planned as it is meant to disappear in future releases.

At the python level, let me quote David:

we have different options. For pseudos from the pseudo-dojo, we could use a string identifier corresponding to a specific PD table/xc/version etc ... for a given atom. This will need a few changes in the pseudo_dojo package as well but it is worth it (there are some drawbacks with the current situation). [...] We also need to allow for custom pseudos.

This issue concerns how to handle pseudopotentials.

There are probably two things there. The first one is how are they handled at the python level. The other one is how the actual abinit input file is written.

For the abinit input file, we have decided with @gmrigna that we won't support the versions of abinit before 9.2 and only support running abinit without the .files file (see B.7 in the release notes of abinit v9.2 : https://docs.abinit.org/about/release-notes/). That means that the pseudos will be handled with the pseudos variable (https://docs.abinit.org/variables/files/#pseudos), possibly together with the pp_dirpath.

At the python level, we have different options. For pseudos from the pseudo-dojo, we could use a string identifier corresponding to a specific PD table/xc/version etc ... for a given atom. This will need a few changes in the pseudo_dojo package as well but it is worth it (there are some drawbacks with the current situation but I will not get into details here). We also need to allow for custom pseudos.