abekoh / commit-plantuml-action Goto Github PK

9.0 9.0 5.0 186 KB

This action generate diagrams (png) from PlantUML files (*.puml), and commit to pull-request. Also this can add review comment of diff files.

License: GNU General Public License v3.0

Dockerfile 12.76% Shell 87.24%

github-actions plantuml

commit-plantuml-action's Introduction

Hi, I'm abekoh 👋😝

Resume (in Japanese)

Works

MICIN, Inc. (2021-)
Yahoo! Japan Corp. (2018-2021)

Likes

Go
TypeScript
Rust
GraphQL

Links

→ abekoh.dev

commit-plantuml-action's People

Contributors

Stargazers

Watchers

Forkers

crmitchelmore erzz angelo-dnastack zaphiro-technologies

commit-plantuml-action's Issues

if no change is made to any puml file, action fails

It looks like that when no change is found, the process returns some error code causing the action to fail:

Run abekoh/[email protected]
  with:
    botEmail: [email protected]
    botGithubToken: ***
    enableReviewComment: true
/usr/bin/docker run --name c044[2](https://github.com/zaphiro-technologies/architecture/actions/runs/4569215558/jobs/8065199580#step:4:2)eefaed692aa746708482a9ce0af60a1f_a[3](https://github.com/zaphiro-technologies/architecture/actions/runs/4569215558/jobs/8065199580#step:4:3)bff9 --label 6c0[4](https://github.com/zaphiro-technologies/architecture/actions/runs/4569215558/jobs/8065199580#step:4:4)42 --workdir /github/workspace --rm -e "INPUT_BOTEMAIL" -e "INPUT_BOTGITHUBTOKEN" -e "INPUT_ENABLEREVIEWCOMMENT" -e "HOME" -e "GITHUB_JOB" -e "GITHUB_REF" -e "GITHUB_SHA" -e "GITHUB_REPOSITORY" -e "GITHUB_REPOSITORY_OWNER" -e "GITHUB_REPOSITORY_OWNER_ID" -e "GITHUB_RUN_ID" -e "GITHUB_RUN_NUMBER" -e "GITHUB_RETENTION_DAYS" -e "GITHUB_RUN_ATTEMPT" -e "GITHUB_REPOSITORY_ID" -e "GITHUB_ACTOR_ID" -e "GITHUB_ACTOR" -e "GITHUB_TRIGGERING_ACTOR" -e "GITHUB_WORKFLOW" -e "GITHUB_HEAD_REF" -e "GITHUB_BASE_REF" -e "GITHUB_EVENT_NAME" -e "GITHUB_SERVER_URL" -e "GITHUB_API_URL" -e "GITHUB_GRAPHQL_URL" -e "GITHUB_REF_NAME" -e "GITHUB_REF_PROTECTED" -e "GITHUB_REF_TYPE" -e "GITHUB_WORKFLOW_REF" -e "GITHUB_WORKFLOW_SHA" -e "GITHUB_WORKSPACE" -e "GITHUB_ACTION" -e "GITHUB_EVENT_PATH" -e "GITHUB_ACTION_REPOSITORY" -e "GITHUB_ACTION_REF" -e "GITHUB_PATH" -e "GITHUB_ENV" -e "GITHUB_STEP_SUMMARY" -e "GITHUB_STATE" -e "GITHUB_OUTPUT" -e "RUNNER_OS" -e "RUNNER_ARCH" -e "RUNNER_NAME" -e "RUNNER_TOOL_CACHE" -e "RUNNER_TEMP" -e "RUNNER_WORKSPACE" -e "ACTIONS_RUNTIME_URL" -e "ACTIONS_RUNTIME_TOKEN" -e "ACTIONS_CACHE_URL" -e GITHUB_ACTIONS=true -e CI=true -v "/var/run/docker.sock":"/var/run/docker.sock" -v "/home/runner/work/_temp/_github_home":"/github/home" -v "/home/runner/work/_temp/_github_workflow":"/github/workflow" -v "/home/runner/work/_temp/_runner_file_commands":"/github/file_commands" -v "/home/runner/work/architecture/architecture":"/github/workspace" [6](https://github.com/zaphiro-technologies/architecture/actions/runs/4569215558/jobs/8065199580#step:4:7)c0442:eefaed692aa[7](https://github.com/zaphiro-technologies/architecture/actions/runs/4569215558/jobs/8065199580#step:4:8)46708482a9ce0af60a1f
From https://github.com/zaphiro-technologies/architecture
 * [new branch]      add-deployment-view-to-eda-10 -> origin/add-deployment-view-to-eda-10
 * [new branch]      architecture-glossary  -> origin/architecture-glossary
 * [new branch]      feature-issue-template -> origin/feature-issue-template
 * [new branch]      main                   -> origin/main

inputsの値の与え方考え直す

https://docs.github.com/en/free-pro-team@latest/actions/creating-actions/dockerfile-support-for-github-actions
ここに書いてあるとおりのargsだとうまく行かない？

→INPUT_XXXにリマップしてるっぽい

/usr/bin/docker run --name cc4956d56a62f5ab244e508a4aa4b7421628e3_f18187 --label cc4956 --workdir /github/workspace --rm -e INPUT_BOT-EMAIL -e INPUT_BOT-GITHUB-TOKEN -e INPUT_ENABLE-REVIEW-COMMENT -e HOME -e GITHUB_JOB -e GITHUB_REF -e GITHUB_SHA -e GITHUB_REPOSITORY -e GITHUB_REPOSITORY_OWNER -e GITHUB_RUN_ID -e GITHUB_RUN_NUMBER -e GITHUB_RETENTION_DAYS -e GITHUB_ACTOR -e GITHUB_WORKFLOW -e GITHUB_HEAD_REF -e GITHUB_BASE_REF -e GITHUB_EVENT_NAME -e GITHUB_SERVER_URL -e GITHUB_API_URL -e GITHUB_GRAPHQL_URL -e GITHUB_WORKSPACE -e GITHUB_ACTION -e GITHUB_EVENT_PATH -e GITHUB_ACTION_REPOSITORY -e GITHUB_ACTION_REF -e GITHUB_PATH -e GITHUB_ENV -e RUNNER_OS -e RUNNER_TOOL_CACHE -e RUNNER_TEMP -e RUNNER_WORKSPACE -e ACTIONS_RUNTIME_URL -e ACTIONS_RUNTIME_TOKEN -e ACTIONS_CACHE_URL -e GITHUB_ACTIONS=true -e CI=true -v "/var/run/docker.sock":"/var/run/docker.sock" -v "/home/runner/work/_temp/_github_home":"/github/home" -v "/home/runner/work/_temp/_github_workflow":"/github/workflow" -v "/home/runner/work/_temp/_runner_file_commands":"/github/file_commands" -v "/home/runner/work/commit-plantuml-action/commit-plantuml-action":"/github/workspace" cc4956:d56a62f5ab244e508a4aa4b7421628e3

→うまくいかず？

もうちょっと試す必要ありそう

ライセンス見直し

PlantUMLがGPLっぽいからこれもGPLにせないかんかも

fatal: unsafe repository ('/github/workspace' is owned by someone else)

※ 日本語にて失礼します。

Version

1.0.1

Actual Behavior

name: pull_request
on:
  pull_request:
    paths:
      - '**.puml'
jobs:
  generate:
    runs-on: ubuntu-latest
    timeout-minutes: 10
    steps:
      - uses: actions/checkout@v2
      - name: generate and commit diagrams
        uses: abekoh/[email protected]
        with:
          botEmail: xxxxxxxxx
          botGithubToken: ${{ secrets.PAT_GITHUB }}
          enableReviewComment: true

上記の設定にて、2022/04/12までは正常に動作をしておりました。
personal access tokenは repo(Full control of private repositories)を選択しています。

2022/04/13にGithub Actionにて以下のエラーが発生しております。

fatal: unsafe repository ('/github/workspace' is owned by someone else)
To add an exception for this directory, call:

	git config --global --add safe.directory /github/workspace

Further info

おそらく以下のGitの脆弱性アナウンスによる影響だと推察しております。

https://github.blog/2022-04-12-git-security-vulnerability-announced/