abbernie / tune Goto Github PK

Would be great to be able to install this library via npm install --save such that it can be imported using require or import.

Hello,

I'm using tuna but today I saw some issues related with deprecation:

tuna-min.js:1 [Deprecation] DelayNode.delayTime.value setter smoothing is deprecated and will be removed in M64, around January 2018. Please use setTargetAtTime() instead if smoothing is needed. See https://www.chromestatus.com/features/5287995770929152 for more details.
set @ tuna-min.js:1

tuna-min.js:1 [Deprecation] AudioParam value setter will become equivalent to AudioParam.setValueAtTime() in M65, around March 2018 See https://webaudio.github.io/web-audio-api/#dom-audioparam-value for more details.
set @ tuna-min.js:1

tuna-min.js:1 [Deprecation] GainNode.gain.value setter smoothing is deprecated and will be removed in M64, around January 2018. Please use setTargetAtTime() instead if smoothing is needed. See https://www.chromestatus.com/features/5287995770929152 for more details.
set @ tuna-min.js:1

tuna-min.js:1 [Deprecation] BiquadFilterNode.frequency.value setter smoothing is deprecated and will be removed in M64, around January 2018. Please use setTargetAtTime() instead if smoothing is needed. See https://www.chromestatus.com/features/5287995770929152 for more details.
set @ tuna-min.js:1

tuna-min.js:1 [Deprecation] BiquadFilterNode.gain.value setter smoothing is deprecated and will be removed in M64, around January 2018. Please use setTargetAtTime() instead if smoothing is needed. See https://www.chromestatus.com/features/5287995770929152 for more details.
value @ tuna-min.js:1

tuna-min.js:1 [Deprecation] BiquadFilterNode.Q.value setter smoothing is deprecated and will be removed in M64, around January 2018. Please use setTargetAtTime() instead if smoothing is needed. See https://www.chromestatus.com/features/5287995770929152 for more details.
value @ tuna-min.js:1

I am trying to write a tuner that can take an arbitrary frequency in hz and suggest a note for it.

I realize that the "note" suggested would be dependent on which scale I'm using. Although it'd be possible to have the user declare which scale they want to use, it'd be better if the software could check amongst multiple scales and show all the matches. This project seems like the most promising resource to do this which is why I'm asking.

Hello ,
First of all thank you for this interesting library.
I forked the project to run the keyboard demo you provided and so uploaded it on my host, but after clicking the first key, I got the following error and none of the keys work after that. I mean they have no sound.

error:
Tone.min.js:5023 Uncaught TypeError: Failed to set the 'value' property on 'AudioParam': The provided float value is non-finite.
would be great if you could help me with the issue.

You might wanna give a license, and also show the license and copyrights of the work from which you took the data...

• setKey could be postponed until 0.2. It is not totally necessary for 0.1
• .search() currently searches the titles of the scales. It could be nice to have a function that searches the descriptions of the scales. For example, some scale descriptions contain the word "Byzantine" but no titles do.
• I am interested in the possibility of creating a single UI component to accompany this library. I imagine a matrix where each row is an octave of the scale, each column is a note in the scale, and certain intervals are highlighted for reference (for example, if the scale contains a perfect 5th (3/2) over the tonic, that cell would be red).
• Some way to export builds of tune.js that only contain one or two scales (of a user's choice). I don't mind having a 1MB library, but some users might, since any application is likely to only use a few of the 3000 scales.
• a responsive / phone-friendly scale archive
• visualizations or ratio descriptions in the scale archive (could be on separate pages, linked to from the main page).

Hi Andrew, Hi Ben,

Do you guys have an example using tune-api-only.js? I want to use this in the next version of Gibber, but I don't want to add a file quite this big, so I'd like to load the scales on-the-fly off a server. I noticed there's a global TuningList in the file... I guess I should just write a download function to populate that?

Anyways, I was curious if you had some ideas for best practices for this use case, since you went to the trouble to break the functionality out into a separate file from the tunings themselves. Hope you're both well! - Charlie