aaronp / agora Goto Github PK

Instead of just flatmapping futures, we seem to need to Await a future in side the workspace future in order to be able to cancel an execution.

in ExecutionWorkflow:

    /**
      * TODO - work out what the chuff is going on. We seem to need this workspace thread to block until the HttpResponse
      * is **prepared** ... not completed, but at least created.
      *
      * Taking this blocking awaitWorkspace out here will fail the ExecutionWorkflowTest
      */
    logger.trace(s"Waiting for ${runProcess.httpResponsePreparedTimeout} for job '${jobId}'s http response to be prepared")
    val prepareResponse: HttpResponse = Await.result(httpFuture, runProcess.httpResponsePreparedTimeout)
    logger.trace(s"Job '${jobId}'s http response ready w/ ${prepareResponse.status}")

Manually triggered workspace client checks for files currently just check the existence of the file.
We should be a bit smarter about this so we don't trigger dependencies before files are completely written to.

One approach may be to use .metadata files to shadow workspace files to mark when files are 'ready'

Remove the swagger plugin which uses jackson json (not circe) and instead generate the routes either from the same derivation as circe (hard ?) or via a json example (as we should have examples anyway) ... and deconstructing json types is a lot easier :-)