aarmoa / blockchain-developer-bootcamp-final-project Goto Github PK

Hey @aarmoa Great job on your Final Project! We'll be approving it on the course itself in a week or two, but here's your feedback in the meanwhile:

Frontend

• Not sure if this is a feature of scaffold-eth or you built it in, but having the user click a button to switch networks is awesome!
• Ditto around the date selection, not sure if you did this integration, but it's very smooth and nice
• Really like the visual layout of the committed payments showing up, fantastic

Contract Design and Testing

• Commenting on your Solidity code was top-notch, again helped navigation and comprehension immensely.
• The upgradability aspect you incorporated into your contract is impressive, any thoughts as to what you would upgrade or anticipate upgrading? Or was it merely the desire to implement?
• Really liked the Solidity function cancelCommittedPayments() and claimAvailablePayments(), specifically the optimization technique you mentioned where you would actually remove the value from the array. Nice touch!

Overall

• Really appreciated how clear and thorough your README was, Abel. Made it very straightforward to navigate your project, high open-source standard met here.
• Really great use of scaffold-eth and awesome testing! Great job!