Improve --kernel-version and --cmdline about kconfig-hardened-check HOT 4 OPEN

Hi @jvoisin,

The --autodetect mode is incompatible with others and requires something like this:

assert(args.config is None and
       args.cmdline is None and
       args.sysctl is None and
       args.print is None and
       args.generate is None), \
       'unexpected args'

So I think the --autodetect mode checking kconfig, cmdline, and sysctls should be implemented in separate if block, similarly to if args.print and if args.generate in the current code.

I would propose reimplementing it in the current PR and get the final --autodetect argument behavior before merging.

from kconfig-hardened-check.

Hi @jvoisin,

I like this idea.

I see 2 additional features for --autodetect:

• Try using /proc/config.gz before searching in /boot/.
• Also check the current sysctl state.

What do you think?

Thank you!

from kconfig-hardened-check.

Yup, those were on my todo-list (I should have mentioned it here tbh), but I wanted to see if you'd be interested in this before adding them.

I think I'd make sense to get this one merged, and then pile features on top of it :)

from kconfig-hardened-check.

Done in #130.

from kconfig-hardened-check.