Code Monkey home page Code Monkey logo

Comments (6)

a13xp0p0v avatar a13xp0p0v commented on July 30, 2024

Yes, tired of various codecov failures, just like everyone else :)

Currently, codecov version 4 requires a secret token for uploading the coverage reports.
That's why the pull requests from forked repositories can't use codecov and CI fails.

As a compromise, I've created two separate GitHub Actions without coverage control:
https://github.com/a13xp0p0v/kernel-hardening-checker/actions/workflows/engine_unit-test_no-coverage.yml
https://github.com/a13xp0p0v/kernel-hardening-checker/actions/workflows/functional_test_no-coverage.yml
These should work for each pull request.

But the original actions with the coverage control will fail anyway.

What do you think about that?

from kconfig-hardened-check.

jvoisin avatar jvoisin commented on July 30, 2024

Another way would be simply have a condition in the codecov job, to prevent it from running in pull-requests,

from kconfig-hardened-check.

a13xp0p0v avatar a13xp0p0v commented on July 30, 2024

Cool, thanks!
I've added such a condition.

Could you please rebase any pull request?
We should see only no-codecov tests working.

from kconfig-hardened-check.

jvoisin avatar jvoisin commented on July 30, 2024

It's working \o/

from kconfig-hardened-check.

a13xp0p0v avatar a13xp0p0v commented on July 30, 2024

Nice, thanks, Julien!

By the way, excuse me for not-so-fast handling of issues and pull requests.
I'm working on this project in my spare time (however very regularly).

from kconfig-hardened-check.

jvoisin avatar jvoisin commented on July 30, 2024

By the way, excuse me for not-so-fast handling of issues and pull requests.
I'm working on this project in my spare time (however very regularly).

No need to apologise :)

from kconfig-hardened-check.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.