7uc0 / play-liquibase Goto Github PK

Play's config parser accepts hash signs as values for properties. This means that comments should be on a line of their own. I didn't know that, so I wrote:

liquibase.active=true # some comment here

The result was that the property value was "true # some comment here", which is not equal to "true", hence is interpreted as "false". It took my quite some head scratching to figure out why this was happening. As a solution, I would add a bit of code like this to the LiquibasePlugin class:

if (autoupdate == null) return;
if (!"true".equals(autoupdate) && !"false".equals(autoupdate)) {
    throw new ConfigurationException("Invalid value for liquibase.autoupdate: " + autoupdate);
}

That way invalid values are much easier to debug.

Liquibase's commands.py causes an error to be shown on every play command:

~ !! Error while loading /home/sybren/project/modules/liquibase-2.3/commands.py: name 'play_command' is not defined

It's not a blocking error, but it's also not something I want to see. Removing or editing the commands.py works, until the next "play dependencies" command, which will reinstall the buggy file.

See the commands.py that's shipped with Play's "secure" module for a structure that does work.

Tested on Liquibase plugin version 2.3 and Play 1.2.3