64 / cmake-raytracer Goto Github PK
View Code? Open in Web Editor NEWRay tracer written in pure CMake
License: MIT License
cmake-raytracer's People
Contributors
Stargazers
Watchers
Forkers
tobiasberling fidergo-stephane-gourichon narayanr7 neomatrixcode xsession lyrl jadematrix bpycinski leggenda47 benmcmorran thanhloi1 bollu disinicmake-raytracer's Issues
Update image in README
Support image dimensions that aren't powers of two
As per the README:
For now, to keep the code simple, you are required to keep image_width, image_height and num_procs as powers of 2, otherwise the image may not be fully formed.
This shouldn't be too hard to fix.
Artifacts on the sample image
The sample image has some artifacts: for example, the part of the "floor" which is the nearest to the camera appears convex.
README section for windows
I am not sure how would you like to format this or if you would even want to include it at all hence an issue and not a pr.
powershell:
1, 2, 4, 8, 16, 32, 64, 128, 256, 512 | foreach {Write-Host $_; (Measure-Command { cmake . "-Dimage_width=$_" "-Dimage_height=$_" "-Dnum_procs=$Env:NUMBER_OF_PROCESSORS" 2> image_size_$_.ppm }).TotalSeconds }sample performance:
config: i7-10700 8C/16T with cmake 3.21.0-rc2 run for 16 threads .
output:
1
3.3046483
2
3.2815196
4
3.381609
8
1.8510678
16
1.9677127
32
1.8989169
64
3.2966402
128
12.1628932
256
47.9041449
512
184.0473142
Magic number in to_fp()
While I was reading the code, I noticed this in line 248, in to_fp():
string(SUBSTRING ${frac_part} 0 6 frac_part)Why 6? What does it stand for? Rounding? But why round a number to 6 decimal points here? I just can't make sense of it.
Incorrect renderer
You do not have a shadow in the reflection on the sphere, the shadow on the tile from the sphere. )))
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.