623637646 / impressionkit Goto Github PK

Thank you for the nice library.

Can you also support View on SwiftUI?

是否可以支持一下OC

First, thank you for making a nice kit.

For example, if the frame of ScrollView in the example app is CGRect(x: 0, y: self.view.frame.height / 2, width: self.view.frame.width, height: self.view.frame.height / 2),

AreaRatio doesn't seem to be calculated normally.

Thanks.

var impressionGroup: ImpressionGroup = {
let impression = ImpressionGroup.init {(_, index: IndexPath, view, state) in
}
impression.redetectOptions = [.leftScreen]//no work
UIView.redetectOptions = [.leftScreen]//usefull
return impression
}()

If user selects .didEnterBackground as redetection Option and puts the application background then in foreground ImpressionKit doesn't detect impressions properly.

Here's the steps to reproduce

1. Launch App
2. Select Redetect When didEnterBackground from Settings
3. Select UICollectionView (reused views) from Demos
4. Slowly scroll to the bottom of the CollectionView. Make sure all views are impressed (marked with green color).
5. Once all cells are impressed (marked with green color) scroll to the top of the CollectionView then scroll to the bottom of the CollectionView
6. Put application to background
7. Bring the application to the foreground

Result: Application gets into foreground state however all cells are already marked with green color -impressed. (Sometimes - cells stays on white color or impression only works partially for some cells). Also logs doesn't show any indication of redetection.

Expected behaviour: Impression should be redetected - Cell colors should be White- Red-Green.