We have now for balances a moshi type adapter that would better be pushed down to svalinn.

The class in question is in io.gnosis.data.db.TypeConverters.kt>class BigDecimalNumberAdapter

As just discussed with @rmeissner:

I think it would be great if this lib could move to MIT license. IANAL but for me it seems that it is currently it is not easy to move code from this library to Kethereum - even though this is even a mission statement in the README. It would be great if both libraries could use the same license - and now it is still easy as there are just 2 contributors that even sit in the same office. It get's more complex the more contributors there are. Also a reason why it is more complicated in KEthereum as there are 7 contributors that would need to agree on a change.

• Move android specific stuff to app
  e. g.: Libs that handles formatting and string representation that is bound to the app
• Add lib content to app ui module (utils package / class)
• Identify logic that can be moved to Kethereum

Can't import the package to use Ethereum Blockies

Graddle.app:
implementation 'com.github.gnosis:svalinn-kotlin:blockies:0.15.0'

Gladle Settings:
maven { url 'https://jitpack.io' }

ERROR:
Failed to resolve: com.github.gnosis:svalinn-kotlin:blockies
Show in Project Structure dialog
Affected Modules: app

Currently the build process relies on Travis. As Gnosis has moved to GitHub action this project should also be migrated.

Notes:

• Remove GITHUB_API_KEY usage as it will be deleted beginning of July
• Same has to be done for Bivrost: 5afe/bivrost-kotlin#63

It should be possible to use encodePacked with Types

Expected behavior

Releases should supply jar files where possible. Also, wherever Rx is used it should be optional and there should be a coroutine based alternative.

Actual behavior

Currently, every release supplies aar files. Libraries that are not required as "Android libraries" should be exposed as "Java libraries" (thusly generating jar files instead) so we can consume them in a wider variety of projects.

Steps to reproduce the behavior

Add any implementation call in gradle to any artifact from a pure kotlin project. The dependency fetched is an aar file which is not usable by a project that is not android related.

Progress:

• utils-testing split into:

  • utils-testing-rx
  • utils-testing (if it makes sense to write the coroutine counterpart)
  • utils-testing-android

• utils split into:

  • utils-rx
  • utils (if it makes sense to write the coroutine counterpart)
  • utils-android

How to test it, this is my error log:
Class not found: "pm.gnosis.crypto.HDNodeTest" Empty test suite.

Using a signature containing a chain_id in the v cannot be used for recovery.

When we see that the v of the signature is > 35 we should adjust it, for this it is necessary that we know the chain id.

This is only used when recovering a sender from a transaction hash with the signatures (not sure if we ever do that)

Hello,

thanks for your work. It is works well but doesn't support arrays in EIP712. Could you please add it or provide some info how to add it correctly?