48klocs / dim-wish-list-sources Goto Github PK

What

616582331 is not in the manifest anylonger I beleive. My automation caught it.

// Cry Mutiny
//notes:pandapaxxy (PvP Controller): Recommended MW: Blast Radius “Cry Mutiny is not fantastic at any one thing being both grenade and melee focused. But it is unique in being one of three heavy weapons with incandescent. Of the three this is the easiest to get and one of the better weapons to get incandescent on. Roar of the Bear coming from Iron Banner is a rocket, which has better use cases. Fixed Odds coming from the Duality dungeon and feels impossible to farm for. Cry Mutiny gives this to players in an easy to get format.   For PvE I would use it with Solar builds, especially as one of your minor killing weapons. For PvP I would look elsewhere. The perks do not lend themselves to the best experience. “ (Solar Grenade Launcher Heavy Ammo)|tags:pvp
dimwishlist:item=616582331&perks=332773068,332133599,3523296417,4082225868
dimwishlist:item=616582331&perks=1478423395,332133599,3523296417,4082225868
dimwishlist:item=616582331&perks=332773068,332133599,4293542123,4082225868
dimwishlist:item=616582331&perks=1478423395,332133599,4293542123,4082225868
dimwishlist:item=616582331&perks=332773068,332133599,3523296417,1546637391
dimwishlist:item=616582331&perks=1478423395,332133599,3523296417,1546637391
dimwishlist:item=616582331&perks=332773068,332133599,4293542123,1546637391
dimwishlist:item=616582331&perks=1478423395,332133599,4293542123,1546637391

$ grep -L -i notes * | grep .txt                          ~/code/dim-wish-list-sources
mercules_black_armory_and_sotp_rolls.txt
mercules_black_armory_pulse_bow.txt
mercules_crown_of_sorrow.txt
mercules_dreaming_city_breakdown_rolls.txt
mercules_erentil_and_opulence_iron_banner.txt
mercules_gambit_rolls.txt
mercules_iron_banner_bonus.txt
mercules_iron_banner.txt
mercules_last_wish_rolls.txt
mercules_menagerie.txt
panda_black_armory_picks.txt
panda_black_armory_pve_picks.txt
panda_black_armory_pvp_picks.txt
panda_forsaken_pve_rolls.txt
panda_forsaken_pvp_rolls.txt
panda_missing_black_armory_pve.txt
panda_missing_black_armory_pvp.txt
panda_penumbra_pve.txt
panda_penumbra_pvp.txt
panda_season_drifter_pve.txt
panda_season_drifter_pvp.txt

Around 21 files are missing any notes at all. I would propose we add the Currator + whether they marked it as PvE or PvP and if they intend it for console vs M&K.

Example being from panda_black_armory_picks.txt
I would propose:

  3 //dead man walking (pvp pc)
  2 //notes: PandaPaxxy's PC PvP pick
  1 dimwishlist:item=3751622019&perks=445755710,3142289711,1168162263,2846385770
  0 dimwishlist:item=3751622019&perks=445755711,3142289711,1168162263,2846385770
  1 dimwishlist:item=3751622019&perks=445755704,3142289711,1168162263,2846385770
  2 dimwishlist:item=3751622019&perks=445755710,3177308360,1168162263,2846385770

I can help and throw up a PR for it. But don't want to go through it all if it is unwanted. This would help give silly new light players(like myself) an easier way to know why a gun was wishlisted or be able to find the source from DIM, or to be able to see which wishlist guns are PvP//PvE.

Possible notes added would be (for Panda as an example):

//notes: PandaPaxxy's pick
//notes: PandaPaxxy's PvE pick
//notes: PandaPaxxy's PvE PC pick
//notes: PandaPaxxy's PvE Console pick
//notes: PandaPaxxy's PvP pick
//notes: PandaPaxxy's PvP PC pick
//notes: PandaPaxxy's PvP Console pick

The ID for Sacred Provenance should be 2408405461 instead of 3385326721 for the Panda picks. ID is correct for Mercules’ picks.

What

I found what I beleive is the unintended perk hash for Archer's Tempo in a small protion the wishlist txt file.

I see 1718750057 which is a sandbox perk 9 times.
I see 201365942 which is a inventory item trait 417 times.

Incorrect data is contained in this portion of the data if I'm right.

// Imperial Needle (PvP first choice roll)
//notes:Inspired by Destiny Massive Breakdowns from Podcast 201. PvP first choice roll.
dimwishlist:item=3460122497&perks=852209214,3429800428,1718750057,47981717
dimwishlist:item=3460122497&perks=852209214,3827198035,1718750057,47981717
dimwishlist:item=3460122497&perks=852209214,3311977193,1718750057,47981717
dimwishlist:item=3460122497&perks=852209214,3429800428,2450788523,47981717
dimwishlist:item=3460122497&perks=852209214,3827198035,2450788523,47981717
dimwishlist:item=3460122497&perks=852209214,3311977193,2450788523,47981717

// Imperial Needle (PvE first choice roll)
//notes:Inspired by Destiny Massive Breakdowns from Podcast 201. PvE first choice roll.
dimwishlist:item=3460122497&perks=852209214,3429800428,1718750057,2726471870
dimwishlist:item=3460122497&perks=852209214,3827198035,1718750057,2726471870
dimwishlist:item=3460122497&perks=852209214,3311977193,1718750057,2726471870
dimwishlist:item=3460122497&perks=852209214,3429800428,1718750057,4082225868
dimwishlist:item=3460122497&perks=852209214,3827198035,1718750057,4082225868
dimwishlist:item=3460122497&perks=852209214,3311977193,1718750057,4082225868

@48klocs - 👀

I know it's a big part of but a lot of rolls are either very outdated or just straight up terrible recommendations which make no sense. Other lists are helpful but pandapaxxy list makes recommended perk feature almost useless.

Hello,

I noticed that a Bug-Out Bag roll by "Inspired by @DestinyMBP Podcast vs Enemies episode 61" on lines 8827-8835 in voltron.txt had the wrong order for hashes. It has "3230963543" (Flared Magwell) in the 5th column and "4293542123" (Incandescent) in the 4th column.

// Bug-Out Bag (PvE first-choice roll)
// (Extended Barrel, Chambered Compensator), (High-Caliber Rounds, Armor-Piercing Rounds, Ricochet Rounds), Threat Detector, Incandescent
//notes:Inspired by @DestinyMBP Podcast vs Enemies episode 61 (https://open.spotify.com/episode/4XT0gPkoVSh3cM6gMtSupq?si=18db495353ca49ad) with @ImpetusAlways, @Saint_Kabr and @CourtProjects. First-choice PvE pick for Solar synergy and Minor add-clearing in end-game content. If you haven't got an Incandescent Calus Mini-Tool, the Bug-Out Bag could be a very acceptable alternative. Decent stats but, if you get Threat Detector as a perk, you can pretty much ignore stability, handling and reload with your barrel choices, so you might as well control the recoil a little instead - Extended Barrel or Chambered Compensator take the Recoil Direction to a near-perfect 98. Any of the Combat Effect magazine perks adds utility, and a little range on top. In the first trait column as the support perk, Threat Detector at two stacks takes stability to around 80 and maxes out handling and reload speed and Incandescent as the second column signature perk is great for add clearing and builds into your scorch and ignite Solar verbs. Recommended MW: Range, with a damage-boosting (Minor or Taken Spec) or Backup Mag mod.|tags: PvE, PvE-MinorSpec, PvE-God, PvE-EndGame, M+KB, Controller
dimwishlist:item=2832639510&perks=1467527085,1561002382,4071163871,4293542123,3230963543
dimwishlist:item=2832639510&perks=3661387068,1561002382,4071163871,4293542123,3230963543
dimwishlist:item=2832639510&perks=1467527085,1968497646,4071163871,4293542123,3230963543
dimwishlist:item=2832639510&perks=3661387068,1968497646,4071163871,4293542123,3230963543
dimwishlist:item=2832639510&perks=1467527085,1885400500,4071163871,4293542123,3230963543
dimwishlist:item=2832639510&perks=3661387068,1885400500,4071163871,4293542123,3230963543

edit: I haven't played in a bit and thought Incandescent was an origin trait. So not a mixup but still an issue.

I wasn't really able to find any way of viewing some UI for the wishlist. Maybe there is some secret menu in DIM i don't know about?

But it would be nice to just take:
wishlist.txt -> render items in DIM
or even just
wishlist.txt -> readable_wishlist.csv

Thoughts?

Hi developer, first of all, my Eglish is bad, so I'll try my best to tell you how masterwork in the wishlist file is broken.

I got a One Small Step last week, and the roll is:
Smallbore / Extended Mag / Quickdraw / One-Two Punch, Reload.
This is a godroll right? But DIM didn't show me as a godroll, fortunately, I've read panda's Reddit post I know this is a godroll so I didn't shard it.
When I fully masterworked it, the symbol appears.↓

What a big problem! If I haven't read that post, I may have already shard this. I tested my ANCIENT GOSPEL (Fluted Barrel / Extended Mag / Rapid Hit / Swashbuckler, Range - t2) use dimwishlist:item=48643186&perks=1840239774,2420895100,247725512,4082225868,684616255
the same thing happened, no symbol. ↓

Hope you understand what I say, Imagine how many people will shard the weapon that should have been retained. Please fix this.

Edit: Panda's godroll spreadsheets

I don't PVP, and thus I'd love a PVE only wishlist.

Is this something that's possible?

Other than that I can only say thanks for making the game just that bit easier to understand and get into.

Season 20 Iron Banner weapons aren't matching the wishlist, previous weapons like:

Roar of the Bear
Gunnora's Axe
The Hero's Burden
etc.

Hitmark HCS, High-Caliber Rounds, Demolitionist, Dragonfly

Found at https://github.com/Butlins12/destiny-rolls

the typhon gl5 entries from yeezy have column the origin trait in the 3rd column rather than the 5th... i don't think this will match any guns?

or do i have to copy&paste all files together to use them inside DIM ?

thanks for all that work!!!

There's quite a lot of notes added (through script IIRC) to old individual rolls files but just realised there are no notes for this weapons in the voltron equivalent. I noticed a lack of notes in voltron but I thought those weapons didn't have notes in their original files. I just used the "panda_season_drifter_pve.txt" and "panda_season_drifter_pvp.txt" on dim to see what's what with my gnawing hungers and to my surprise there's notes in there.

So there's a problem transfering this to the voltron file?

As seen here - DestinyItemManager/DIM#7077

Found at https://github.com/Butlins12/destiny-rolls

Some of the rolls for deliverance in the list (ex. dimwishlist:item=2886339027&perks=1392496348,2969185026,2014892510,1890422124) are using the hash identifier of Cataclysmic (Adept) instead of Deliverance (Adept), which should be 2943293195. This results in DIM creating a wishlist that

Looks like this

Instead of this

See DestinyItemManager/DIM#10256

on gun "the number", extended mag shouldn't be in the barrel column for wishlist rolls:

In the current version, I see this syntax, I think description is intended to go on it's own line.

title:Season 15 (Season of the Lost) Astral Alignment weapons from Podcast 228
description:Season activity weapon rollsdimwishlist:item=1622998472dimwishlist:item=1622998472

I think you want

title:Season 15 (Season of the Lost) Astral Alignment weapons from Podcast 228
description:Season activity weapon rolls
dimwishlist:item=1622998472dimwishlist:item=1622998472

@48klocs 👋

When going through the wishlisted rolls for the Hezen Vengeance VoG rocket launcher, I noticed the second roll breakdown has incorrect phrasing when describing the benefits of the Overflow perk.

It reads: "Inspired by Destiny Massive Breakdowns from Podcast 234. PvE first choice roll for boss DPS - get a kill, reload to get two in the tubes and throw a grenade for a quick third. Recommended MW: Reload with Boss Spec mod." The roll shown below the text is Quick Launch / Impact Casing / Overflow / Demolitionist.

The focus here is "get a kill, reload to get two in the tubes." I believe that the text has Overflow confused with Ambitious Assassin, which is not an available perk on Hezen Vengeance. Overflow only increases magazine capacity when picking up special or heavy ammo, and is not activated on reload after a kill like Ambitious Assassin is. See above pictures for reference. <3

Hello,

In voltron.txt on line 52509 there is a typo of "backupe roll":

// Lingering Dread (PvE backupe roll)
// Smart Drift Control, Spike Grenades, Auto-Loading Holster, Vorpal Weapon
//notes:Inspired by DMB Player Versus Enemies Podcast 19. PvE backup roll for solo yellow bar burst damage. Bitterspite origin trait is excellent - faster reload is always useful. The first breech-loading Stasis Grenade Launcher is a great utility weapon. Smart Drift Control helps a bit with handling and velocity, and Spike Grenades boosts single target damage. Auto-Loading Holster lets you swap and continue damage with a primary while reloading and Vorpal Weapon adds a flat 15% damage boost. Recommended MW: Handling or Velocity, with a damage-boosting (Major, Boss or Taken Spec) mod.|tags:pve
dimwishlist:item=2026087437&perks=3300816228,1546637391

There are a couple of other instances of the same typo on lines 35788 and 35816.

something's weird about how rollable sword guard types are set up, and the invalidator is claiming only the default guard type can exist. need to investigate how/why that's structured differently in the manifest

From my gist comments, user @stanotomic pointed out...

There is a little bug I encountered : the hash id for Black Powder is 1996142143 not (199614214)

There are over 9000 duplicate rolls in the voltron.txt file that get dropped when the file is parsed. It'd be great to filter those out ahead of time as part of generating the overall file.

not sure where to report this: but on choosy_voltron the twilight oath has a thumbs up for opening shot in column 2 ... that's not a valid perk in this column:

Right now voltron is manually created via lot's of copy-pasta. There are duplicate entries with (possibly) conflicting notes. The source files have changed over time, at the same time the same changes would need to be search replaced in Voltron etc. While this is nice and works well and most likely is in a good state.

It would make sense that Voltron would be an automatically generated file. It would be nice if we had a file called something like FileMeta.json that in there would look something like:

[
  {
      "filename": "panda_sundial_controller.txt",
      "curator": "Pandapaxxy",
  },
  {
      "filename": "panda_black_armory_pve_picks.txt",
      "curator": "Pandapaxxy",
      "pick_type": "PvE",
  },
]

On the first pass, I would be as simple as possible, add notes when they are missing, have a very basic copy-pasta style that we do currently. Most likely that is good enough for our use cases. But it should make voltron easier to maintain since we only need to work withspecific smaller files and then can just trust that voltron just works

We could get fancier with auto-genning notes and de-duping if an item is in multiple lists to make sure the comment reflects it being in multiple lists. Etc. Maybe combine the notes into a single note. But for now it's good for us to know that voltron is accurate to the source material.

There is a few lines for toil and trouble that have it roll with slideshot and full auto trigger system, despite the fact they both roll in the 3rd column. Couldn't work out exactly where the roll was sourced from, most recent list above it is "// from https://docs.google.com/spreadsheets/d/1D4Fu6fSoSrPhlSOmCn_n1bItSNGZHbZxNI6_lVpoeB8/edit#gid=0", but that last doesn't list toil and trouble.

Could be intended as a god roll because you can then switch between the two, but seems odd to specify 2 perks in the same column.

Rolls:
dimwishlist:item=2957367743&perks=1047830412,791862061,3161816588,2117683199
dimwishlist:item=2957367743&perks=1332244541,791862061,3161816588,2117683199
dimwishlist:item=2957367743&perks=1047830412,1087426260,3161816588,2117683199
dimwishlist:item=2957367743&perks=1332244541,1087426260,3161816588,2117683199
dimwishlist:item=2957367743&perks=1047830412,106909392,3161816588,2117683199
dimwishlist:item=2957367743&perks=1332244541,106909392,3161816588,2117683199
dimwishlist:item=2957367743&perks=1047830412,791862061,3300816228,2117683199
dimwishlist:item=2957367743&perks=1332244541,791862061,3300816228,2117683199
dimwishlist:item=2957367743&perks=1047830412,1087426260,3300816228,2117683199
dimwishlist:item=2957367743&perks=1332244541,1087426260,3300816228,2117683199
dimwishlist:item=2957367743&perks=1047830412,106909392,3300816228,2117683199
dimwishlist:item=2957367743&perks=1332244541,106909392,3300816228,2117683199

Found at https://www.blueberries.gg/weapons/destiny-2-seasonal-weapons/

pandapaxxy's GoS weapons hashes are almost correct now, but Reckless Oracle still has the same id as Prophet of Doom. Reckless Oracle id should be 3385326721.

Hello,

I wanted to know when the wishlist will be updated for Season 20 (Defiance) and the Lightfall expansion.

I am currently not trashing some of my new rolls since I'm not sure what's deemed worthy or ass.

Grenade launcher treated as SMG with SMG comments.

Ive been combing over the source lists and found two issues.

1. One weapon entry will have the same set of rolls repeated up to 3-4 times. This may be isolated to the panda_shadowkeep sheets. The entry below should only be the first four lines but somehow it was duplicated. Its considerably worse on others, which feeds into the second thing i noticed.

// Exit Strategy
dimwishlist:item=4227181568&perks=839105230,1885400500,205890336,4082225868
dimwishlist:item=4227181568&perks=839105230,1885400500,4071163871,4082225868
dimwishlist:item=4227181568&perks=839105230,1885400500,205890336,3708227201
dimwishlist:item=4227181568&perks=839105230,1885400500,4071163871,3708227201
dimwishlist:item=4227181568&perks=839105230,1885400500,205890336,4082225868
dimwishlist:item=4227181568&perks=839105230,1885400500,4071163871,4082225868
dimwishlist:item=4227181568&perks=839105230,1885400500,205890336,3708227201
dimwishlist:item=4227181568&perks=839105230,1885400500,4071163871,3708227201

2. Some of these weapons will have two sets of rolls, pointing to different hash IDs. This was present on the majority of panda's sheets. One ID points to the actual usable item, while one is just a "dummy item" which has the listed description

"These items are not actually ones you can obtain in the game, but rather are used to display information."

I figure cleaning these lists up will only help future updates, whether its creating custom lists, adding more notes or splitting the lists to create customizable voltrons. I have already went though all of the panda lists and could finish the rest if it would help.

FYI, I just updated to the latest version of recommendations and found a line with a trailing tab that caused a bug in my app.
dimwishlist:item=3164743584&perks=1482024992,106909392,3436462433,2213355989

The trailing tab was inconsistent with other rows and figured you would want to know about this.

From a relatively new player perspective, it is not easy to find a good granade launcher. I was surprised Edge Transit with mentioned perks is marked as trash. It is worst than Wendigo, also than some 150 rpms, but not trashy. Please adjust, especially for new players, old ones will manage this.

Got a report over on Discord.

Waking Moment
Chambered + Extended + Slideways + Swashbuckler

From panda's spreadsheet (not sure which)

• check to verify that the perk hashes are all correct.
• check to verify that Waking Moment's item hash is correct (and that a second inventory item definition hasn't sprouted)

Hi there,

I've been maintaining my own personal fork of the project so that I can add my own custom wishlist rolls to the voltron files. I've just been adding them directly to those files, but I'd like to keep things a little more organized and mantain my own "content creator" folder like you have them set up. I can certainly figure out how to add a new folder for the existing scripts to look at. However, I can't figure out for the life of me what code is actually used to compile the voltron files! Neither of the scripts set up in the package.json seem to do it, and there is no main index.js file (or its .ts counterpart) anywhere.

I'm new to node, so I apologize if I'm missing anything obvious. 😅

Thank you for compiling this resource and making it available to DIM!

bivalent/DIM-to-LL-converter#1 (comment)
For reference, this is a link to an issue describing the mismatching files that I'm forwarding to this repository to review.

--

There seems to be a mismatch between various files of this repository. For example, the front-facing files (voltrons) and the list generation tool both seem to use the same format. Links to them:

https://raw.githubusercontent.com/48klocs/dim-wish-list-sources/master/choosy_voltron.txt

and the provided list generation tool:
https://48klocs.github.io/wish-list-magic-wand/fingerwave.html

However, those are both different than the files found here:
https://github.com/48klocs/dim-wish-list-sources/blob/master/AyyItsChevy/super_pog_s14.txt

Is there a tool or system in place that can adjust the formatting so they're all the same? I'd like to have my script (DIM format to Little Light format) work across all the files in this repository for folks looking to upload and adjust what they find here.

I have found a few example where the hashes are for different weapon perks than intended.

Some I found, there might be more (just showing the first line for brevity)

// Tripwire Canary
dimwishlist:item=3849444474&perks=839105230,3142289711,247725512,1015611457

// Cold Front
dimwishlist:item=2814093983&perks=3250034553,3142289711,1428297954,2846385770

// Aurvandil FR6
dimwishlist:item=963710795&perks=839105230,3230963543,247725512,124408337

// Avalanche
dimwishlist:item=495940989&perks=839105230,1087426260,3300816228,2939589096

PS. The last one seems to be for Enhanced Target Lock, but the weapon is not craftable.