Comments (5)
Sorry, we are not going to enable the squash merging, please rebase your branch correctly before merge (with one or more commits as needed)
from apicast.
You do not need that to improve your PR. You can do it using git. You'll need to become familiar with terms such as amend
, fixup
, and squash
. git rebase -i
can help you a lot. A tutorial like this one might help you get started: https://www.atlassian.com/git/tutorials/rewriting-history
from apicast.
I know, but I tend to mess it up which is why I thought it would be nice and easier if we could just enable that option on the repo ;)
from apicast.
As I understood, this feature does squashing only at the moment of doing a merge. But I think it indeed would be useful to rebase the branch before that, before making the branch ready for review, to make it easier for the reviewer.
from apicast.
rebasing to make sure the delta is the real delta versus head of master - absolutely.
But different thing from squashing to combine commits and make cleaner, no?
from apicast.
Related Issues (20)
- backend.t HOT 1
- resolver.t HOT 2
- balancer.t HOT 1
- apicast-upstream-balancer.t
- management.t
- apicast-mapping-rules.t
- backend-cache-handler.t
- Review and update DNS-resolver doc HOT 5
- Setup local env fails HOT 13
- Retiring the probot-changelog app HOT 1
- Trigger Alert `CoreDNSErrorsHigh` with OpenShift 4.11.9 HOT 2
- Swagger compatibility Issue HOT 5
- Edge Limiting is sharing the hits across windows HOT 3
- GRPC integration tests HOT 1
- OpenTelemetry instrumentation does not use environment variable OTEL_RESOURCE_ATTRIBUTES HOT 1
- Need help with build failure on power HOT 2
- lua-rover issue faced while enabling support for power(ppc64le) architecture HOT 4
- Immediate, infinite recursion when configuration loader is set to `boot` and reloading is disabled HOT 2
- Keycloak roles and services under roles HOT 1
- Make prove command failing while enabling support for power(ppc64le) architecture. HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from apicast.