Code Monkey home page Code Monkey logo

Comments (2)

hector-vido avatar hector-vido commented on August 22, 2024

I think in two options here:

  • add some logic inside http.d/init.conf or cli/environment.lua;
  • a second conf/nginx.conf.liquid for tests;

First option can be a problem because it will change some almost static files to a more dynamic one, but this is better than a second file with a lot of duplicated content and another block inside Blackbox.pm

The Problem

  • There is two calls to resty.resolver - one inside environment.lua and another inside init.conf.
  • These two calls related to resty.resolver initialization do not pass the path parameter, ignoring any attempt to configure a custom resolv.conf.

These are the code that APIcast execute:

-- http.d/init.conf
require('resty.resolver').init()
-- cli/environment.lua
local resolver = require('resty.resolver')
resolver.init_nameservers
  • If these functions are called without the path parameter, the machine/container /etc/resolv.conf and the RESOLVER environment variable - if defined - will be added to the list of nameservers.
  • If one of the functions are called with the path parameter, the custom resolv.conf will be added together with /etc/resolv.conf and the RESOLVER environment variable.

Proposal

Remove one of the resty.resolver calls and standardize the name of the variable that points to a custom resolv.conf.
Calling both these functions with path parameter will duplicate the nameservers.

Since this needs more modifications than a single file and a environment variable name, I will wait for suggestions.

from apicast.

hector-vido avatar hector-vido commented on August 22, 2024

This pull request #1432 is working but since there is a commented line and a "strange" variable name, more discussion is desirable.

from apicast.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.