3a4ot / datetoolsobjc Goto Github PK

When submitting an app with this framework (built with Carthage), iTunesConnect reports this error:
"This bundle .../Frameworks/DateToolsObjC.framework is invalid. The Info.plist file is missing the required key: CFBundleVersion."

When I build the framework for iOS, the CFBundleVersion entry is left out of the Info.plist. This causes its app to get rejected by Apple's automatic .ipa validation.

This was introduced in commit (- Added Swift Package Manager support., 349a899) when building for iOS. The previous 1.0.3 release doesn't have this problem.

Test:

• checkout master/1.0.4
• open the project
• select an iOS target
• build
• right click on DateToolsObjC.framework in the file navigator in Xcode and select Show In Finder
• Open the folder and then look at the Info.plist file

Expected:

• With the 1.0.3 release there was an entry for CFBundleVersion that was set to 1.0.0
  Actual:
• No entry for CFBundleVersion

Unfortunately I can't quite figure out what in the commit caused this specifically?

See also: #4

Nowadays mixed iOS projects (Swift, Objective-C) dependencies no longer need to be linked as dynamic frameworks. So we can start to link statically and improve app launch time.

• change framework type to Match-O

• Update Carthage archive script for .travic.yml

• Update README.md and point that from 1.0.6 we link statically.