2talltyler / itl_houses Goto Github PK

Now redundant thanks to disable_item in header.nml

Fix tabbing and colon placement (why did I format this like a lang file?)

Unless Lumberjack Industries is loaded.

As seen in the middle of this city, a handful of buildings that originate in the temperate climate have appeared here. I was unsure if this was intentional, but upon checking the scenario editor, these buildings Years are 1700 to 65535, and are the only buildings to have that date range. That would appear like an oversight to me in which case?

In OpenTTD, the NewGRF description says to see the website for more information. This links to the README here on GitHub, which needs more screenshots and a rewrite to better communicate the ideas of Improved Town Layouts rather than simply listing detailed rules.

This should be completed before releasing 1.2.0.

Hello! We are having an issue with RVG and were wondering if ITL may be causing some conflict (or maybe we don't know what we are doing) - any ideas?

...which use the protected flag.

Photo credit: Kale on Discord

Here is a town created without ITL in 1860. There appear to be six housing sprites in total...

• Small cottage
• Medium cottage
• Large cottage
• Double thatched roof house A
• Double thatched roof house B (w/ pond)
• Townhouse triplets A ("two-up, two-down")
• Townhouse triplets B

Here is a town created with ITL in 1860. There are four housing sprites that better fit in a post-war timeperiod. They are...

• South-facing doubles w/ garages
• South-facing single bungalow w/ garage
• East-facing 2-story doubles
• East-facing 1-story doubles

The good news is that the previously listed historical houses (cottages and townhouses) still spawn, but in far fewer number than the aforementioned homes which seem to be the primary type of house that spawns. There's also a single sub-arctic housing sprite that appears in these towns. Maybe intentional?

Upon digging and experimenting in the scenario editor, I believe I have found the 'culprit'...

All of the circled houses are 'dynamic', with the red/orange set cycling between those 4 sprites previously listed, and the blue/green set cycling between two townhouse triplets. It seems the red and blue houses were added with fractional cargo requirements to support the early game, but with the perhaps unintentional issue of introducing housing sprites designed to be post-automobile into the 19th century.

In the vanilla game, the red/orange set are coded to appear in 1931 (the orange set in ITL appears in 1945. suggesting how the red set was added later and thus 'broke' the timeline). The blue/green set (the two-up/two-downs as they're actually called) appear from the year 0 in vanilla game, but 1945 in ITL. I would concur with the vanilla game's interpretation; the two-up/two-downs were built well before the 20th century. They would be most appropriate in the inner city/town area, rather than suburb.

Really want to do a historical run with ITL temperate, so hopefully this can get fixed! :D

• Use ternary operators when possible to eliminate switches
• Replace strings of deny/continue switches with a single switch checking multiple things (yes, &&)
• Use better names!

Graphics

• Random tree sprites on ground tile
  • May need sub-randomizers to avoid identical x/y coordinates when placed in a straight line
• Ground tile depends on terrain - use example code on spritelayout wiki page

Placement

• May only build 1 tile from another park tile (unless no other park tiles exist in town) OR a river tile
• Protected if 1 tile from another park tile (2 adjacent tiles are permanent)
• Don't build in TOWNZONE_CENTRE

Lifespan

• Experiment with lifespan and probability to determine optimal values. How long should it take for two tiles to spawn adjacent to each other and become protected?

Delete unused switches to eliminate NMLC warnings.

The above is the current houses that can appear in ITL in sub-arctic climate.

This is the vanilla game's list of buildings for the sub-arctic climate. Perhaps intentional?

Version

1.1.1

Expected result

Commercial buildings transition smoothly from brick buildings to skyscrapers

Actual result

Brick commercial buildings all cease being available in 1945 and only a few skyscrapers become available

Steps to reproduce

Start a game in 1940, build a bus network to grow the city, and fast-forward

Suggested fix:

Stagger the ending dates of brick buildings and create new historic preservation switches using each end date

This completes what PR #5 began.

Version

1.1.1

Expected result

• Each building has its own set of switch blocks, following an easy-to-understand naming convention
• Each building, plus its spritelayouts, switches, etc., live in their own file

Actual result

• Switch blocks are shared by many different buildings, with an inconsistent naming scheme
• Buildings are merged by type of building, with sprites and switches in their own files

Steps to reproduce

Look at the repository

Suggested fix

• Copy each building to its own file
• Copy switches and spritelayouts to the new file and rename them to match the building
• Update Python and Batch makefiles

Your repository is kind of different compare to other repo on GitHub in the sense that people usually cannot access this repo release page by UI. However it still can be access directly to the webpage by its link: https://github.com/2TallTyler/improved_town_layouts/releases

Just for comparison:

Version

1.1.0

Expected result

Attempting to lower the land underneath a park, statue, or fountain follows the behavior of lowering land underneath other town buildings.

Actual result

The land is not lowered and an error is produced.

Steps to reproduce

Attempt to lower the land underneath a park, statue, or fountain.

Suggested fix:

Parks, statues, and fountains currently have the HOUSE_FLAG_NOT_SLOPED flag. This was intended to keep them from building on sloped tiles, but not to prevent the player from modifying the terrain. Suggest adding this logic to the construction_check instead. Yes, I'm talking to you, future me.

Many landmarks and commercial buildings are protected if they are within the catchment area of a station which received Goods, Food, or Passengers last month.

One month isn't quite long enough for many delivery chains, particularly when using trains. Checking whether said cargo was delivered either last month or this month would make the check more reliable, on average extending the period by 15 days.

Use:
cargo_accepted_nearby_last_month(FOOD) == 1 || cargo_accepted_this_month(FOOD) == 1

Two parameters were broken by the move to the cargo_production loop in the Waste & Recycling update. They are unnecessary as I intend for them to always be used, and should be removed.

• Improved Mail
• Improved Early Population

Note: This will also require removing ternary operators on individual houses.

...in Waste production switch.

The next ITI update will add Waste acceptance to the Farm (feeding to the pigs). With that update, push an ITL update which removes the year >= 1882 restriction in the waste production loop.

9999 may not be far enough in the future for extremely long games. Try 7FFFFFFF and see if NMLC will accept it.