22digital / laravel-cashier-fastspring Goto Github PK

This project forked from bgultekin/cashier-fastspring

💳 Laravel Cashier Fastspring is a cashier-like Laravel package which provides an interface to the Fastspring subscription and payment services.

Home Page: https://fastspring.22digital.co.za

License: MIT License

PHP 100.00%

fastspring laravel laravel-5 laravel-5-package laravel-6 laravel-6-package laravel-application laravel-cashier laravel-fastspring laravel-framework laravel-package laravel-payment laravel-payment-gateway laravel-payments

laravel-cashier-fastspring's Introduction

22digital

laravel-cashier-fastspring's People

Contributors

Stargazers

Watchers

Forkers

d3n4 ahkmunna incevio kapilthapa divinedominion barazasalim24 wedevsofficial supuna97

laravel-cashier-fastspring's Issues

The assignment to ``$customer`` is dead and can be removed.

IssueId: 41885590
Message: The assignment to $customer is dead and can be removed.
Filename: src/SubscriptionBuilder.php
LineNumber: 110
Link: https://scrutinizer-ci.com/g/22digital/cashier-fastspring/issues/master/files/src/SubscriptionBuilder.php?selectedLabels%5B0%5D=2&orderField=path&order=asc&honorSelectedPaths=0&issueId=41885590

\ApiClient($username, $password) is incompatible with the declared type ``array`` of property ``$instance``

IssueId: 41885617
Message: It seems like new TwentyTwoDigital\CashierFastspring\Fastspring\ApiClient($username, $password) of type TwentyTwoDigital\CashierFastspring\Fastspring\ApiClient is incompatible with the declared type array of property $instance.
Filename: src/Fastspring/Fastspring.php
LineNumber: 35
Link: https://scrutinizer-ci.com/g/22digital/cashier-fastspring/issues/master/files/src/Fastspring/Fastspring.php?selectedLabels%5B0%5D=7&orderField=path&order=asc&honorSelectedPaths=0&issueId=41885617

The expression ``return implode(' ', $parted)`` returns the type ``string`` which is incompatible with the documented return type ``object``

IssueId: 41885598
Message: The expression return implode(' ', $parted) returns the type string which is incompatible with the documented return type object.
Filename: src/Billable.php
LineNumber: 292
Link: https://scrutinizer-ci.com/g/22digital/cashier-fastspring/issues/master/files/src/Billable.php?selectedLabels%5B0%5D=18&orderField=path&order=asc&honorSelectedPaths=0&issueId=41885598

The assignment to ``$subscriptionPeriod`` is dead and can be removed

IssueId: 41885619
Message: The assignment to $subscriptionPeriod is dead and can be removed.
Filename: src/Listeners/SubscriptionActivated.php
LineNumber: 77
Link: https://scrutinizer-ci.com/g/22digital/cashier-fastspring/issues/master/files/src/Listeners/SubscriptionActivated.php?selectedLabels%5B0%5D=2&orderField=path&order=asc&honorSelectedPaths=0&issueId=41885619

Call to undefined function TwentyTwoDigital\CashierFastspring\Tests\studly()

Describe the bug

vendor/bin/phpunit
PHPUnit 7.5.17 by Sebastian Bergmann and contributors.

Warning:       opcache.save_comments=0 set; annotations will not work

................................................................. 65 / 70 ( 92%)
....E                                                             70 / 70 (100%)

Time: 778 ms, Memory: 18.00 MB

There was 1 error:

1) TwentyTwoDigital\CashierFastspring\Tests\WebhookControllerTest::testWebhooksEvents
Error: Call to undefined function TwentyTwoDigital\CashierFastspring\Tests\studly()

/tests/WebhookControllerTest.php:185

StyleCI failing

Describe the bug
StyleCI is failing on some of the tests in the repo.
See details over here

Diff file contains the following:

diff --git a/tests/CashierFastspringTest.php b/tests/CashierFastspringTest.php
index 2811f170b284b67abbbc963c1e5fde4630ec2387..486871791d5b082f0de7ec914a0c2988dda83695 100644
--- a/tests/CashierFastspringTest.php
+++ b/tests/CashierFastspringTest.php
@@ -128,8 +128,8 @@ class CashierFastspringTest extends TestCase
                 ],
             ])),
             new Response(200, [], json_encode(['accounts' => [
-                    ['id' => 'fastspring_id'],
-                ],
+                ['id' => 'fastspring_id'],
+            ],
             ])),
             new Response(200, [], json_encode(['hello' => 'world'])),
         ]);
diff --git a/tests/SubscriptionTest.php b/tests/SubscriptionTest.php
index 99d70505c39d8765e036729f2672af04877ab05b..1d5dd6410ce93f0a9f0b8814c4bb77bd12f83af8 100644
--- a/tests/SubscriptionTest.php
+++ b/tests/SubscriptionTest.php
@@ -81,7 +81,7 @@ class SubscriptionTest extends TestCase
             'subscription_id' => 'fastspring_id',
             'start_date' => $today,
             'end_date' => $today,
-            'type' => 'local'
+            'type' => 'local',
         ]);
 
         $this->assertNotNull($activePeriod);

Multiple parameters are not used and could be removed

studly_case() has been deprecated: Str::studly() should be used

IssueId: 41885607

Message: The function studly_case() has been deprecated: Str::studly() should be used directly instead. Will be removed in Laravel 6.0.
Filename: src/Http/Controllers/WebhookController.php
LineNumber: 56
Link: Click here

IssueId: 41885609

Message: The function studly_case() has been deprecated: Str::studly() should be used directly instead. Will be removed in Laravel 6.0.
Filename: src/Http/Controllers/WebhookController.php
LineNumber: 60
Link: Click here

title_case() has been deprecated: Str::title() should be used

IssueId: 41885663

Message: The function title_case() has been deprecated: Str::title() should be used directly instead. Will be removed in Laravel 6.0.
Filename: src/Listeners/SubscriptionChargeCompleted.php
LineNumber: 58
Link: Click here