2003scape / rsc-c Goto Github PK

User complained that the rsc-c client (which we host as an unlinked to beta) has a bad right click menu.

https://gitlab.com/open-runescape-classic/core/-/issues/3408

i think it has to do with faces that are near-0 in colour

fixed with:

if (vertex_colour.r <= 0.0f && vertex_colour.g <= 0.0f && vertex_colour.b <= 0.04f  ) {
    discard;
}

but i'd rather do it before it gets sent to the shader

Potential Enhancement OpenRSC server can view a list of all online players.
RSC-C simply cashes when this command is used currently.

having to modify 4 different structures to add a new option is a pain

Probably not worth doing this Fully Customizable Runelite Style since RSC doesn't have many items to begin with. Colour coding for items like rune and dragon, ignore bones/ashes, etc.

create an option for it

utilize separate sprites per sector and metadata from https://github.com/2003scape/rsc-landscape

Looks like another NPC is being drawn under him.

bring back belt buckles, pretty eyes, bat mouths, etc.

There's a sound glitch with the client
Was mass buying feathers from shop, 200 of em
Was spam clicking buy
After I was done buying the sound just kept looping on and on, even after I clicked log out
Ok tested it again seems it's not infinite it just loops each buy sound for all 200 feathers

some people hate it

This code is pretty doomed:

https://github.com/2003scape/rsc-c/blob/master/src/ui/menu.c#L1318

    int walkable = selected_face != -1;

#if defined(RENDER_GL) || defined(RENDER_3DS_GL)
    walkable = mud->scene->gl_terrain_walkable;
#endif

    if (walkable) {
[...]

selected face can be -1 on an OpenGL client when a menu is generated.

This results in using -1 as an array index:

                mud->menu_item_x[mud->menu_items_count] =
                    mud->world->local_x[selected_face];

                mud->menu_item_y[mud->menu_items_count] =
                    mud->world->local_y[selected_face];

Which triggers the undefined behavior sanitizer and (in my case) triggers a segfault.

The fix is not as simple as changing the if statement to check that selected_face != -1, that breaks walking.

Someone who understands the OpenGL code please look at this.

I've had luck reproducing around Draynor Manor's vampire basement.

nix MUD_IS_COMPACT at compile time and dynamically switch to compact UIs if the window size is smaller than 512x346.

implement rs2 music for areas. use https://github.com/schellingb/TinySoundFont/

it's terrible but it should be included and available in additional options. disabled by default.

https://github.com/2003scape/rsc-censor has the most comprehensive refactoring i think

Is as title says. Attempted to run both on the vWii and 3ds causes the consoles to freeze really bad. The Wii-U had to have it's power cable pulled out because it completely stopped responding. It gets stuck trying to contact the server.

some scenery was added only after pay-to-play and is seldom used elsewhere. this includes:

• fireplace
• dead tree
• blue flowers
• some of the ferns found around yanille
• damaged earth
• crude bed

there are two unused signs which could be added without negative effects:

• The rising sun
• The forester's arms

instead of using https://github.com/2003scape/rsc-c/blob/master/texture-pack/texture-pack.js to create atlases ahead of time, utilize https://github.com/vonhoff/maxrect-c (which uses a ported implementation of the JS packer) and the sprites within the jag cache files to populate atlases on game load. we already create textures dynamically since sleep words, minimap and login scene sprites all require that behaviour.

The GLAD code is simpler, doesn't require us to ship a Windows dll, and probably works on more platforms.

It doesn't like -pedantic though.

why not?

Running on Windows.

Disable ground models in the options menu
Click "Save and Close" on the options interface.
Close the client. Client cannot be opened again. It just crashes with no error message.
The last thing printed to the console is the "Loaded: x frames of animation" message.

This can of course be fixed by going into the options.ini and setting ground_item_models back to 1.

This also occurs if you set ground_item_models = 0 through the ini with the client closed and then try to launch the client.

maybe with an internal setting for different UI eras

Exactly what the title says: I can log into RuneScape from everything BUT this client. This one just gives a connection error.

https://developer.mozilla.org/en-US/docs/Web/Manifest

this should allow for the "Add to Home Screen" functionality with more appropriate icons etc.

It's hard to see text and whole screen at the time.

Attempted to trade with someone and found I could not put up any items to trade from my end. Could however see items being put up for trade from other player.

Hello. I’ve use the QR code to install the port. I’ve tried signing up through the port but get an error

will need to include a PNG encoder. hopefully able to do the filesystem operations in another thread since SD card writing is very slow.

In the RSCP server, after doing the ::onlinelist command (which sends a black box with a list of all the players online) and closing the box by clicking the "Click here to close window" text, the bank interface will open.
The interface will be completely blank, and you won't be able to deposit or withdraw anything.
I haven't been able to reproduce this with any other commands that send black boxes so far.

essential for packaging

make it possible to play multiple sounds simultaneously on 3ds

something to do with the way the login block is encoded by the client

got bank menus disabled, can't even close it.

for add friend/ignore. also support clicking trade requests

Are any up to date releases available with the latest updates for 3DS? I do not have a machine set up to build a CIA for myself and would love to try things out.

Tested on the webclient, when a player is on member area (ex. [512,1923]) and then login happens over free world, then a division by zero crash happens leading to black screen.

There is a stack trace but not sure how meaningful it is:

mudclient.js:225 Uncaught RuntimeError: divide by zero at mudclient.wasm:0x27f14 at mudclient.wasm:0x55d68 at mudclient.wasm:0x473b5 at mudclient.wasm:0x47f22 at mudclient.wasm:0x47c00 at mudclient.wasm:0x15fa8 at mudclient.wasm:0x1279c at mudclient.wasm:0x119c1 at mudclient.wasm:0x2f9c5 at ret.<computed> (mudclient.js:11327:35)

Also a couple of small QOL suggestions if you don't mind, just what I've noticed: clicking on someone in friends list doesn't bring up keyboard like it does on the other client

this can apply to any of the social list popups and offer-x.

To reproduce:

• Teleport to Falador
• Walk to house that has a leather gloves spawn downstairs
• Go up and down ladder repeatedly
• Gloves duplicate

204 protocol.

I’m the all green with orange beard
My screen was switching to the dude in the gnome outfit

not sure what's going on here exactly yet.

I noticed if I try to change the values in game the options.ini file becomes empty.
Edit: Made a pull request

Makes picking up drops, sorting bank, trading easier.