Code Monkey home page Code Monkey logo

hdrimageviewer's People

Contributors

13thsymphony avatar daspr-microsoft avatar imbushuo avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar

hdrimageviewer's Issues

Not recognizing RGBE image color space.

I've converted an image with ImageMagick from TIF in the ProPhoto RGB space to a .hdr file with primaries set to match this color space. Despite this, the color profile is clearly being interpreted as sRGB in this viewer.

See tiff and hdr file here.

https://jbondhus-sharing.s3.us-east-1.amazonaws.com/2022/2022-11-30/attachment.7z

See below for a comparison between the original TIFF and what the HDR image viewer shows of the .HDR file I generated.

_1001695

The file header is as follows in plain text, which looks correct to me - primaries of ProPhotoRGB...

#?RADIANCE
EXPOSURE=0.1
GAMMA=1
PRIMARIES=0.734699 0.265301 0.159597 0.840403 0.036598 0.000105 0.345704 0.35854
FORMAT=32-bit_rle_rgbe

Launch with -forcebt2100 or add the option to app

SDR screen to view HDR pictures, often use the -forcebt2100 , but every time you use cmd to open the software is too troublesome, I want to add the option to turn this parameter on or off in the toolbar of the app.

My current solution way:
Create a .bat file to open the viewer, you can drag the image from any position of the computer to the bat to view it with forcebt2100.
You can also run the .bat directly and open the picture in the app.

Disadvantages: A cmd window will open, you need to close it manually.

And: I used the B2E tool to generate a .exe file that hides the cmd window, with the same effect.

BAT:

@echo off
set filename=%~nx1
if defined filename (hdrimageviewer -forcebt2100 - input:%~nx1
) else (
hdrimageviewer -forcebt2100
)

EXE: Launch HDR Image Viewer With BT2100.zip

Histogram output

Additional enhancement is a 2D histogram, similar to a spectrum analyzer for audio.

Estimated MaxCLL changes based on window size

Thanks for making this great piece of software! I use it all the time to help figure out what's going on in HDR space.

For some reason, the Estimated MaxCLL calculation changes pretty drastically based on the window size. I've noticed it report 300 nits darker if the window is smaller in images that are 600 nits peak.

Is this because it composites the current frame and grabs the brightest pixel rather than looking at the full-res image?

DDS (BC6H, FP16, etc) support

  • determine list of candidate pixel formats
  • how to detect HDR10 based RGB10 images?
  • bonus: use native D3D support for BC[x] formats instead of D2D's expand to FP16?

Add command line flags

@13thsymphony is a very nice tool. Just wondering is it possible to make the software into an .exe file, so that I can call it in cmd, and with “-f” to specify a file name; “-t” to specify render effect; “-b” to specify brightness, and the default is to make the image fullscreen, with the UI being hide?

batch SDR converting

I'm wondering if it's possible to add batch sdr converting command line in this app. It's easy to add and so useful for game screenshots sharing. Thanks.

Add slideshow and prev/next functionality

This will enable image comparison which is a critical use case.
Ideally would use the hotkeys should be those from WPV and even Photos if they don’t conflict.
          Arrow keys for next image in folder
          F11 for full screen
          Alt-enter for full screen too

Memory leak

There seems to be a memory leak in the app. You can see this by opening images one after the other and checking the memory usage: it will go up after opening each image and never goes back down until the app is closed.

Add support for 8K

Loading 8K (7680x4320) images into HDR + WCG Image Viewer results in a black screen. 4K resolution works fine however.

HDR tonemapper clips certain images

HDR peaks clipping:
\grfxshare\Sigma-GRFX\AdvancedColor\Images\Affinity_HDR-merged
_DSC1314_HDR-merge.hdr

Gray floor:
\grfxshare\Sigma-GRFX\AdvancedColor\Images\chasb-hdr-ibl-images
zwinger_night_8k.hdr

Export to SDR format (e.g. JPEG)

When viewing an HDR image that is tonemapped, offer option to export to an SDR image format so it can be viewed on any computer.

Ultra HDR / Gain map images not supported?

These types of images that are a combination of a regular SDR image and an embedded gain map are rising in popularity after Google and others have added support for them. They are however not displayed properly in this app and just show as SDR.

Unable to load any jxr 5120x1440 HDR screenshots

Red Dead Redemption 2 18_01_2022 02_02_14.zip

I just get the message: "Unable to load this image" "The image file may be corrupted or invalid.".
I attached a sample screenshot. I take these screenshots through the xbox game bar/app, and if I change the resolution to 4k on my other monitor, the screenshots can be opened just fine. It's possible the issue is in the way the screenshot is saved, and not in your app, but I have no reason to believe that.

I was trying to debug and fix the issue myself but I'm unable to build yet, as the instructions are not clear to me (and I have no time to delve into it atm): if this is merged #46 I could still look into the issue myself.

the app is just excellent ! but how is it doing a job that almost no viewer can do ?

thank for the app !

how does this app can perfectly displays hdr still images ?
why does .jxr, .exr, .hdr, displays perfectly and why .tif is all dull and washed out from the same hdr .jxr source ?
how does the app signal to windows that it s hdr content and makes the hdr/sdr slider not affects the brightness ?
is there any other viewer with this hdr display capabilities or is the only one besides microsoft photo for .jxr ?
also do you know something other than jxrlib to convert back an .exr, .hdr, back to .jxr while keeping the rec. 2100 color space, st. 2084 pq eotf ?
what are the metadata or the tags that makes the images displays in hdr like that and what tag that make other images not displays in hdr like that ?
nothing appears with imagemagick or exiftool between 2 version of the same .jxr screenshot 1 hdr the other sdr ? everything reports srgb while it s absolutely not the case for .jxr screenshots or .exr, .hdr exports....
where is the documentation for all of that ?

new batch
resolve case_hdr stills

incorrect PQ tracking for .hdr images in "no effect" mode

I did some tests using HDR + WCG viewer using one of our NVIDIA GSYNC HDR10 monitor prototypes. Our debug tools can observe the exact HDR PQ12 codes coming in from the PC to the monitor. And it looks like brightness of a .hdr image displayed by HDR + WCG is about 8.5x too high at default brightness and when selecting Render Effect = No Effect (all other settings have special transformations we don’t want for our tests).

Consider the attached 4k ‘simultaneous contrast’ style test image we use. It has a 1400 nits bright bar at top. At bottom it has a greyscale with 14 steps, starting with 0.02 nits and increasing by 1.5x for every step to the right. We verified that the .hdr brightness is as we want it with 'tev' (see table).

When we display this with an in-house viewer, we get PQ12 values that translate to the correct nits (within RGBE quantization accuracy). Table below shows PQ12 values/nits values we get with HDR+WCG viewer.

We’d be very interested to see a fix, so we can recommend use of this viewer for our partners/monitor makers.

image

image
ContrastTest_0p02_1p5_3840_2160.zip

PS: we did these experiments with Win10 21H2 (19044.1706), and a 27” 4k 144 Hz 1000 nits GSYNC Ultimate monitor (max 1107 nits).

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.