10up / mce-table-buttons Goto Github PK

Describe the bug
In testing #8, David Chabbi came across the following:

UX visual issue. Cell type dropdown needs width increased. Screenshot attached.

Steps to Reproduce

1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error

Expected behavior
Cell type dropdown items should be fully visible within the dropdown.

Screenshots

Environment information

• Device:
• OS:
• Browser and version:
• WordPress version:

• Plugins and version:
• Theme and version:

• Site Health Info:

Additional context

Describe the bug
In testing #8, David Chabbi came across the following:

If you copy the css style over to a new cell. It also copies over the VAlign and H Algin properties from the cell but the dropdowns are not updated.
Screenshot. You can see the text is centered both V and H but not on the properties.

Steps to Reproduce

1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error

Expected behavior

Screenshots

Environment information

• Device:
• OS:
• Browser and version:
• WordPress version:

• Plugins and version:
• Theme and version:

• Site Health Info:

Additional context

Is your enhancement related to a problem? Please describe.
See overall concept in the OSBP guide and example setups on Simple Podcasting, Restricted Site Access, and ElasticPress.

Describe the solution you'd like

• add base GitHub Action
• add .wp-env.json
• add base docker files
• update package.json / package lock files
• add cypress tests

Designs
n/a

Describe alternatives you've considered
n/a

Additional context
n/a

This issue is for tracking changes for the 3.3.1 release. Target release date: TBD January 2022.

Pre-release steps

• n/a

Release steps

• Branch: Starting from develop, cut a release branch named release/3.3.1 for your changes.
• Version bump: Bump the version number in class-mce-table-buttons.php and readme.txt if it does not already reflect the version being released.
• Changelog: Add/update the changelog in both CHANGELOG.md and readme.txt.
• Props: update CREDITS.md with any new contributors, confirm maintainers are accurate.
• New files: Check to be sure any new files/paths that are unnecessary in the production version are included in .distignore.
• Readme updates: Make any other readme changes as necessary. README.md is geared toward GitHub and readme.txt contains WordPress.org-specific content. The two are slightly different.
• Merge: Make a non-fast-forward merge from your release branch to develop (or merge the pull request), then do the same for develop into trunk (git checkout trunk && git merge --no-ff develop). trunk contains the latest stable release.
• Test: Run through common tasks while on trunk to be sure it functions correctly.
• Push: Push your trunk branch to GitHub (e.g. git push origin trunk).
• Release: Create a new release, naming the tag and the release with the new version number, and targeting the trunk branch. Paste the changelog from CHANGELOG.md into the body of the release and include a link to the closed issues on the milestone.
• SVN: Wait for the GitHub Action to finish deploying to the WordPress.org repository. If all goes well, users with SVN commit access for that plugin will receive an emailed diff of changes.
• Check WordPress.org: Ensure that the changes are live on https://wordpress.org/plugins/mce-table-buttons/. This may take a few minutes.
• Close the milestone: Edit the milestone with release date (in the Due date (optional) field) and link to GitHub release (in the Description field), then close the milestone.
• Punt incomplete items: If any open issues or PRs which were milestoned for 3.3.1 do not make it into the release, update their milestone to 3.4.0, or Future Release.

Post-release steps

• n/a

Is your enhancement related to a problem? Please describe.
Once WordPress 5.8 is released, we'll want to test MCE Table Buttons to see if any incompatibility issues arise.

Describe the solution you'd like

• test MCE Table Buttons on WordPress 5.8
• open issues for any incompatibilities noted in testing
• resolve issues identified in testing
• bump "tested up to" version
• if code changes needed due to incompatibilities, ship a plugin release

Designs
n/a

Describe alternatives you've considered
none

Additional context
Related: #8.

Is your enhancement related to a problem? Please describe.
Once WordPress 5.6 is released, we'll want to test MCE Table Buttons to see if any incompatibility issues arise.

Describe the solution you'd like

• test MCE Table Buttons on WordPress 5.6
• open issues for any incompatibilities noted in testing
• resolve issues identified in testing
• bump "tested up to" version
• if code changes needed due to incompatibilities, ship a plugin release

Designs
n/a

Describe alternatives you've considered
none

Additional context
n/a

Is your enhancement related to a problem? Please describe.

#15 added linting action which use the WordPress standard to check the code style for PHP files. We should fix current listing errors to have our linting action passed.

We should make this plugin Gutenberg-compatible, either by extending the core table block or replacing it with a custom block. It's also possible that all this functionality should make it into the core block - will note that with the Gutenberg team as well.

Here's the functionality I've noted in the current plugin and where I think it should go in the Gutenberg paradigm:

Toolbar

• Dropdown button with multiple flyouts
  • Cell
    • Merge table cells
      • NOTE: Has modal when nothing selected
    • Split table cell
  • Row
    • Insert row before (exists with icon)
    • Insert row after (exists with icon)
    • Delete row (exists with icon)
    • — SEPARATOR —
    • Cut table row
    • Copy table row
    • Paste table row before
    • Paste table row after
  • Column (all exist with icons)
    • Insert column before
    • Insert column after
    • Delete column

Sidebar

• Table properties
  • Rows (this is currently only accessible when creating a new table)
  • Columns (this is currently only accessible when creating a new table)
  • Width
  • Height
  • Cell spacing
  • Cell padding
  • Border
  • Caption (checkbox)
  • Alignment (None, Left, Center, Right)
• Cell properties
  • Width
  • Height
  • Cell type (None/Cell, Header cell)
  • Scope (None, Row, Column, Row group, Column group)
  • Alignment (None, Left, Center, Right)
• Row properties
  • Row type (Header, Body[default], Footer)
  • Alignment (None, Left, Center, Right)
  • Height

Links

• Gutenberg: Table block UX: WordPress/gutenberg#2609
• Gutenberg: Tables: no method to define row or column header cells: WordPress/gutenberg#1470
• Gutenberg: Polish the Table block (responsiveness, table settings toggle): WordPress/gutenberg#6314

Is your enhancement related to a problem? Please describe.
It's not obvious the level of support provided for this repo, so let's add some clarification.

Describe the solution you'd like

• add support level section and badge
• add release version badge
• add WP tested up to badge
• add license badge
• move changelog to its own file

Designs

n/a

Describe alternatives you've considered

none

Additional context

n/a

Is your enhancement related to a problem? Please describe.
In testing #8, David Chabbi came across the following:

Cell Options > Advanced options. Options to change border style but no option to change the width of the border. Everything seems to work fine tho and the Css is updateable.

Describe the solution you'd like

Designs

Describe alternatives you've considered

Additional context

Describe the bug

Merging cells and splitting a cell functionality is not available.

Steps to Reproduce

1. Create a 3 by 3 table
2. Highlight two cells
3. Click on Table > Cell
4. See that Merge table cells is greyed out / disabled (same scenario with Split table cell and a single cell selected)

Expected behavior

Merge table cells should be active and function correctly. Same for Split table cell in its use case.

Screenshots

Environment information

• Device: Mac mini (2018)
• OS: macOS Catalina Version 10.15.2
• Browser and version: Firefox 72.0.2 (64-bit)
• Plugins and version: Classic Editor v1.5 and MCE Table Buttons v3.3
• Theme and version:
• Other installed plugin(s) and version(s): WordPress 5.3.2

Additional context

This was originally reported via a comment on November 19, 2019 so it's possible that this cropped up with the 5.3 release on November 12, 2019.

Is your enhancement related to a problem? Please describe.
We're currently on TinyMCE v4.7.11, but support for TinyMCE v4.x is ending on December 31, 2020 though that's for folks on v4.9.x.

Describe the solution you'd like

• update to TinyMCE v5.x

Designs
n/a

Describe alternatives you've considered
none

Additional context
none

Is your enhancement related to a problem? Please describe.

Describe the solution you'd like

• test WP New Relic on WordPress 5.9
• open issues for any incompatibilities noted in testing
• resolve issues identified in testing
• bump "tested up to" version
• if code changes needed due to incompatibilities, ship a plugin release, otherwise use "Plugin asset/readme update" action to update "tested up to" version on .org repo

Designs
n/a

Describe alternatives you've considered
None

Additional context