10mohi6 / oanda-bot-python Goto Github PK

Great little package ! thanks.
I don't understand one thing with the backtesting : If i set the take profit and stop loss, and set the buy and sell exits to False, should have only two outcomes, either it hits TP or SL. Does it also close the position when we also get a contrary position ? is there a option/fix/work around for it

Hi there,

As the title says, it hangs, never finishes, when I use this:

from oanda_bot import Bot

class MyBot(Bot):
    def strategy(self):
        rsi = self.rsi(period=5)
        ema = self.ema(period=10)
        lower = ema - (ema * 0.001)
        upper = ema + (ema * 0.001)
        self.buy_entry = (rsi < 40) & (self.df.C < lower)
        self.sell_entry = (rsi > 60) & (self.df.C > upper)
        self.sell_exit = ema > self.df.C
        self.buy_exit = ema < self.df.C
        self.units = 1000 # currency unit (default=10000)
        self.take_profit = 20 # take profit pips (default=0 take profit none)
        self.stop_loss = 10 # stop loss pips (default=0 stop loss none)
        

MyBot(
    account_id='<acc id>',
    access_token='<token>',
    instrument='USD_JPY',
    granularity='H1', # 1 hour candlestick
).backtest(from_date="2020-12-31", to_date="2021-1-31", filename="backtest.png")

When I CTRL+C, it returns this:

Traceback (most recent call last):
  File "F:\...\advancedBacktest.py", line 18, in <module>
    MyBot(
  File "F:\Python3\...\oanda_bot.py", line 380, in backtest
    self._candles(from_date=from_date, to_date=to_date)
  File "F:\Python3\...\oanda_bot.py", line 125, in _candles
    time.sleep(0.5)
KeyboardInterrupt

If I run without time constraints, it runs to completion in a matter of seconds.
Any ideas what the issue might be?

Any way to have a strategy with two or more pairs at the same time?

Goodmorning,

My name is Benjamin, Thanks for this wonderful code, it works nicely! I'm having issues with implementing the bbands into the strategy. How can I for instance do a self.buy_entry when the price moves under the lower band? I figured it must be something like

self.buy_entry = self.df.C < mean - (std * band)

I found:

return mean + (std * band), mean, mean - (std * band)

I assume these are the three lines (upper band, mean and lowerband), but I can't figure out how to call these in the backtest or run?

Can you help? Thanks!

Benjamin

Hey team, I hope all of you are doing well in these times.

So I have a question, related to calculation precision. I am not that knowledgeable with Python, so I cannot propose a concrete solution.

The issue is that for calculation as a type float is being used as a type, which leads to unstable calculations because of decimals.
I think this can pose a really big issue and is a no-go for us to use this. When decimals are being calculated and everything depends on the floating-point, something else should be used. Because it really depends on which CPU is the machine using, and what is the state of that CPU.

In the Java world, the solution is BigDecimal or a custom implementation.

For an example

bot = Bot(
    account_id='account-id',
    access_token='access-token',
    granularity='D',
    instrument='EUR_USD',
    environment='practice'
)
print(bot._candles(count='6'))

print(bot.rsi(period=5))

Prints a different result every time.

Is there a plan to resolve this in the near future?

EDIT:
Also, this would apply to all calculations inside the app with float as a type

Hi,
Just wondering if there's the possibility to add hours, minutes, and (maybe not so much) seconds to the backtest function? Markets aren't really uniform throughout the whole day and it would be nice to be able to limit the backtest between certain times (e.g., 8:00 AM - 12:30 PM CST).
Cheers