0xpatrickdev / agoric-vault-collateralization-notifier Goto Github PK

Potential Improvements

Client

• show gov params and current collateralization in addNotifier modal (see #4)
• logout button to disconnect email auth session
• disconnect button to disconnect wallet
• add network dropdown
• manual wallet address input

Server

• send email notification when a new Notifier is created or deleted
• handle multiple networks/environments (currently, a server needs to be deployed for each environment)
• rate limiting, perhaps with something like @fastify/rate-limit

Both

• incorporate decimals from displayInfo. Current app assumes 6 for all denoms (see #2)
• GitHub Workflow for CI/CD (see #3)
• use basis points (as in integer) instead of percents to store collateralizationRatios. Users can specify '250.55%' instead of just '250%'.
• ability to edit existing notifiers (versus deleting and recreating)

see Agoric/ui-kit#55

precedent:

Sea Shanty's bot provides real time updates on user mint collateral debt positions. Available on Telegram, it provides an easy way to view USK mint position amount and risk ratio at any time on mobile or desktop.
-- https://docs.kujira.app/dapps-and-infrastructure/usk-stablecoin/how-to-mint-usk

Problem

I've been trying out the application. I put the computer to sleep and when I woke up in the morning this is what I saw. I had received over 100 emails from notifiers that I had already received one email for the first place. The timing is displayed in Europe/Istanbul setting.

Here's the screenshot of the dashboard:

Notifiers

I'm not able screenshot the notifiers page because my verification link is expired and the email I used is a temporary one which I cannot access now.

Logs

I'm not able to export the logs from mailgun but here's a sample log content:

This eamil is sent at 10/17/23 03:46AM Istanbul

{
	"recipient-domain": "czilou.com",
	"log-level": "info",
	"timestamp": 1697503608.7974238,
	"envelope": {
		"sender": "[email protected]",
		"targets": "[email protected]",
		"transport": "smtp",
		"sending-ip": "198.61.254.59"
	},
	"delivery-status": {
		"enhanced-code": "",
		"mx-host": "mail.czilou.com",
		"session-seconds": 1.518,
		"message": "OK",
		"code": 250,
		"utf8": true,
		"attempt-no": 1,
		"description": ""
	},
	"recipient": "[email protected]",
	"id": "UD2-2xUcR3qJz3gN09hknQ",
	"user-variables": {},
	"storage": {
		"region": "us-west1",
		"env": "production",
		"key": "BAABAQV4OE15f7OeRE5PG4OeoM6960SIZA",
		"url": "https://storage-us-west1.api.mailgun.net/v3/domains/sandbox326822b7859d4b1192b346ae3386227f.mailgun.org/messages/BAABAQV4OE15f7OeRE5PG4OeoM6960SIZA"
	},
	"event": "delivered",
	"tags": [],
	"message": {
		"size": 424,
		"attachments": [],
		"headers": {
			"to": "[email protected]",
			"subject": "Inter Vault Alert: Collateralization Level Breached",
			"message-id": "20231017004647.013f22aaeca69177@sandbox326822b7859d4b1192b346ae3386227f.mailgun.org",
			"from": "[email protected]"
		}
	},
	"flags": {
		"is-authenticated": true,
		"is-routed": false,
		"is-system-test": false,
		"is-test-mode": false
	},
	"campaigns": []
}

And here's the MIME:

Mime-Version: 1.0
Subject: Inter Vault Alert: Collateralization Level Breached
From: [email protected]
To: [email protected]
Message-Id: <20231017004647.013f22aaeca69177@sandbox326822b7859d4b1192b346ae3386227f.mailgun.org>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=ascii

Your ATOM vault #0, has crossed below the 365% collateralization level.

To Reproduce

So far I'm not able to reproduce this behavior but I'm curious about your thoughts @0xpatrickdev

Problem

I found that installSesLockdown.js is using SES version 0.18.7 and endojs/endo#1767 says that it's fixed in 0.18.8

Solution

Update SES from 0.18.7 to 0.18.8

First this is pretty amazing!

Twilo offers some great tools for receiving txt messages and phone calls. Here's a link to the API docs https://www.twilio.com/docs/usage/api