0x1f9f1 / open1560 Goto Github PK

aiVehicle does not have a virtual destructor, though it probably should.

Replace font rendering with FreeType (or the SDL_ttf wrapper).

Keys pressed whilst midgets are open are still handled by menus after the midgets have closed. (Lilkely due to UIMenu::CheckInput).

The paletted version of the ford mustang cruiser's dashboard texture is "corrupt". This is likely because it uses the same "cop" palette as the ford mustang fastback.

Seems like (device_flags_1_ & 0x1) controls vsync. (See swCreatePipeline, ddAttach and ddEndFrame)

• Inputs are sometimes captured even when the game is not focused.
• Sometimes keys will get stuck down when using with ALT (most likely due to not handling WM_SYSKEYDOWN/WM_SYSKEYUP).

If you click on a button, but move your mouse away from the click area before releasing, the button can sometimes get stuck on the wrong image.

agiMeshSet and mmBoundTemplate contain asserts (unsigned)M > 0x01000000 and (unsigned)this > 0x01000000 It is unclear what these asserts are for, or if they are actually required.

The game has support for file mapping, but FileStream does not currently support it.

Using -depth 32 currently crashes due to some stuff being hardcoded for 16-bit

Particle animation speed is currently tied to framerate, which is bad.

After enabling reflections in the menu, the tires also have reflections on them.

Similar to how some new games (i.e Midnight Club 2).

The following functions use SEH (__try, __except) handlers:

GameLoop(mmInterface *,mmGameManager *,char *)
Application(int,char * *)
aiMap::Reset(void)
aiMap::Update(void)
aiPath::UpdateAmbients(void)
aiPath::UpdatePedestrians(void)
aiVehiclePolice::Reset(void)
DoStackTraceback(int,int *)
LogStackTraceback(int *,int)
swScanSurfaces(void)
dxiMemoryAllocate(IDirectDrawSurface4 * *,uint)
ipcMessageQueue::MessageLoop(void)
initHaveMMX::initHaveMMX(void)
utimer(void)
__ComputeCpuSpeed(void)

agiMeshSet::DrawNormals can sometimes crash accessing NormalIndices.

The debug font uses 8x8 bitmaps for each character, which can be difficult to read on larger resolutions.

Now that we are no longer pinning the game to 1 core with SetProcessAffinityMask, we may find some thread-safety issues.

mmGame::~mmGame calls aiMap::Clean after deleting this->CullCity (mmCullCity::~mmCullCity).
This is a problem as mmCullCity controls the mmInstance heap and frees it the destructor, but aiMap still contains lists of aiVehicleAmbient and aiVehiclePolice.
These classes inherit from aiVehicleSpline, which contains a pointer to an aiVehicleInstance (offset 0xB4), which inherits from mmInstance, and so is allocated on the mmInstance heap.
When aiMap::Clean attempts to free the ambients and police, they end up trying to free the aiVehicleInstance pointer in aiVehicleSpline::~aiVehicleSpline, but that memory has already been freed as part of the instance heap.

mmAnimDOF has asNode as the parent, which is incorrect.

Pausing (F2) or frame step (Shift + F12) deletes any broken objects

When using dgVoodoo (but not MS DDRAW), the screen appears to be offset by 0.5 pixels (likely due to https://docs.microsoft.com/en-us/windows/win32/direct3d9/directly-mapping-texels-to-pixels). This is most noticable after drawing debug text on the corner of the screen:

agiBitmap leaks its agiSurfaceDesc, and also its agiSurfaceDesc::lpSurface if the texture is temp (starst with *)

Add lua scripting/bindings

Cop chase speed is partically tied to framerate, which can make them very OP at higher framerates.

Although AGI appears to support multi-texturing, support has been removed in a few places:
NoMultiTexture is always set to 1.
agiCurState.MaxTextures is always set to 1.

agiD3DPipeline::BeginGfx:

// test1560.exe

NoMultiTexture = 1;
if (hwcaps.dwDevCaps & 0x4000) {
    agiDisplayf("Separate texture memories (probably a voodoo!)");
    NoMultiTexture = 1;
}
agiCurState.State.MaxTextures = 1;
SeparateTextureMemories = 0;

// am.exe

NoMultiTexture = 1;
if (hwcaps.dwDevCaps & 0x4000) {
    agiDisplayf("Separate texture memories (probably a voodoo!)");
    SeparateTextureMemories = 1;
    NoMultiTexture = 1;
}
if (NoMultiTexture)
    agiRendState::SetMaxTextures(&agiCurState, 1);
else
    agiRendState::SetMaxTextures(&agiCurState, hwcaps.wMaxSimultaneousTextures);
if (agiRendState::GetMaxTextures((char*)&agiCurState) <= 1) {
    SeparateTextureMemories = 0;
} else {
    agiDisplayf("Multitexturing is supported!");
    v41 = v49->D3DDevice->lpVtbl->SetTextureStageState(v49->D3DDevice, 1, D3DTSS_TEXCOORDINDEX, 1);
    __DDTry(
        v41,
        (int)"D3DDevice->SetTextureStageState(1,D3DTSS_TEXCOORDINDEX,1)",
        (int)"C:\\mm\\src\\agid3d\\d3dpipe.c",
        583);
}

agiD3DTexDef::BeginGfx:

// am.exe

multi_texture = 0;

// ...
if (multi_texture
    && agiRendState::GetMaxTextures(&agiCurState) > 1
    && !strncmp(this->Params.Name, "SHADMAP", 7u)) {
    Displayf("Fixing shadow map '%s' for multitexturing...", this->Params.Name);
    surface = (uint16_t*)this->Surface->lpSurface;
    surface_bytes = 0;
    v19 = this->Surface->dwWidth;
    for (i = this->Surface->dwHeight; v19 && i; i >>= 1) {
        surface_bytes += i * v19;
        v19 >>= 1;
    }
    while (surface_bytes--) {
        *surface = ~(((signed int)*surface >> 12) | ((signed int)*surface >> 8) | ((signed int)*surface >> 4));
        ++surface;
    }
}
// ...

mmSurfaceAudio::EchoOn calls car_sim->AddChild(aud_sound8C), however aud_sound8C (TIREWOBBLE1) is already added as a child in mmSurfaceAudio::EnableTireWobble

List of known differences between different game versions

Add support for ZIP archives to allow easier modding and larger files (ARES cannot handle individula files > 0x7fffff bytes)

Virtual functions with the same name are placed in the opposite order to which they are declared.

The following need to be fixed:

• mmCompBase::Action
• JointedStruct::GetCMatrix

Rewrite the graphics pipeline to use a modern graphics API. BGFX may be a good choice.

When using win32 font rendering (but not freetype for some reason), number fonts disappear when after tabbing in. This issue is not present in the retail build, as mmNumber and mmNumberFont were rewritten.

mmShardManager::Init uses car_model->GetHighMesh()->TexDefs[paint_job][1] as the shard texture, however this isn't always valid, such as with the Disco Ball (TextureCount == 0).

mmLoader contains an asCamera, however it doesn't add this camera as a child. This causes asNode::VerifyTree to fail when running with -updatedbg (DebugMemory & 4)

Need to set D3DTSS_MAXANISOTROPY, and maybe some other stuff

On higher resolutions the map can often feel too zoomed out, even when in the zoomed mode.

mmGameRecord::GetVector4 returns a Vector4&, to a local variable on the stack.

(Note mmGameRecord::GetVector4 is unused though, so it's not really a problem).

ERROR: The audio line reference is invalid.

Some places don't properly restore the render state after changing it.

mmFacadeBangerInstance::GetPos returns a Vector3&, to a local variable on the stack.

(Note mmFacadeBangerInstance::GetPos is unused though, so it's not really a problem).

As code is written, try and find ways to avoid the checks for chicago

Use the refl_showroom texture from MM2 for vehicle reflections in the showroom

Add support for a mods folder, which allows overwriting files without putting them in an archive.

This is most useful with the global tex sheet, since otherwise you have to duplicate all the entries from the base sheet when overring it.

The sliders in the escape menu don't render properly depending on their value.

Replace all usage of unsafe printf/scanf/strcpy/strcat/etc. variants with safe ones

Various crash logs to investigate

This function is inlined (and maybe have just been foo = List()), but in aiVehiclePolice::Reset and aiVehicleOpponent::Reset the existing list is just simply zeroed instead of properly freeing the existing entries.

At larger resolutions, mmTextNode can use a lot of memory (~35 MB ingame at 1440p), as all the surfaces are allocated during mmTextNode::Init (via agiBitmap::Init).