Code Monkey home page Code Monkey logo

artifactdb's People

Contributors

0ttah avatar bubblebooy avatar desvelao avatar fragmate avatar ketura avatar qustomqure avatar tayfunturgut avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

artifactdb's Issues

2.0 Changes

Hey guys been working on a redesign of the structure of this repo/package over the last few days. Here's all the changes so far. Going to be pushing them up later to the master. This will break current projects using this as things have moved around and names changed.

Changes

  • Rewrite README
  • Added all new cards
  • Added small artwork for cards to use for lists and improvements
  • Remove . character from file names
  • "NOT_FINISHED" property on cards that still need details filled out
  • Reorder properties for readability
  • Added SignatureCard property
  • Added IsSignatureCard property
  • Remove Bounty property
  • Rename build/ to ci/
  • Renamed RelatedId => RelatedIds
  • Create exported js module
  • Update build script
  • Added missing Armor values
  • Reorder assets folders
    • assets
      • ability
      • artwork
        • large
        • small
      • icon
        • hero
      • fullcard

Missing art for all the cards added in commit ea3edf1

#26
Cards need Large artwork , Small artwork, and associated hero abilities need artwork

  • Assassin's Veil
  • Assassinate
  • Astral Imprisionment
  • Ball Lightning
  • Bracers of Sacrifice
  • Broadsword
  • Buying Time
  • Claymore
  • Cloak of Endless Carnage
  • Collateral Damage
  • Combat Training
  • Dirty Deeds
  • Empower
  • Fight Through the Pain
  • Fountain Flas
  • Friendly Fire
  • Healing Salve
  • Hero's Cape
  • Heroic Resolve
  • Incarnation of Selemene
  • Keenfolk Golem
  • Keenfolk Plate
  • Magnus
  • Mazzie
  • Melee Creep Dire
  • Messenger Rookery
  • Murder Plot
  • Nyctasha's Guard
  • Oglodi Catapult
  • Outworld Devourer
  • Pick a Fight
  • Platemail
  • Potion of Knowledge
  • Relentless Pursuit
  • Rising Anger
  • Rumusque Vestments
  • Shiva's Guard
  • Smeevil Armsmaster
  • Sniper
  • Steel Reinforcement
  • Stonehall Pike
  • Storm Spirit
  • Town Portal Scroll
  • Trebuchets
  • Tyler Estate Censor
  • Unsupervised Artillery
  • Vesture of the Tyrant
  • Wingfall Hammer

Ability IDs

Ability IDs will allow them to be searched for and listed on their own reference the card that owns them.

card rankings

would you be interested in maintaining tier lists published by third parties in this DB's schema? would have to add a field for each rater. we have a few already we could start populating, i.e. crokey, stancifka

Artifact keywords

Do you plan to add Artifact keywords definitions? (Cleave, condemn, rapid deployment, regeneration, etc...) I think that it would interesting.

"Yellow" color--arbitrary or official?

Is the Yellow color used on items an actual official usage or was that done as a bit of a joke? If it's not official, this should probably be altered to "Item" or "None", lest new factions in the future act as a monkey wrench.

Pulse is missing

In the card manifest, there's a flag for "GetInitiative", but no flag for Pulse. There is also no indicator in the text descriptions where that symbol is located; if the โ™บ symbol isn't desired, you could use @ instead.

https://artifactwiki.com/wiki/Pulse

Improvement suggestions

Suggestions:

DB Restructure

  • Create a file by card and other file for set info. It's more organized of this way in my opinion. You can check if a card is included at database, seeing file names, for example.
  • Create a card and set json templates files with all fields.
  • Create a script (npm run build) to build a compiled db file (cards-manifest.json) with all cards + set info. Now there are +5k lanes and it's complicated manage it.
  • Maybe organize jsons card inner sets folders with set name as folder name, idk.

Fixs

  • Rename fileName field to FileName or Filename due to rest fields start with capital letter.

Images
I found this post on reddit with cards images reacreted by u/Nocturne25: Imgur Album. Interesting if we can't get other images, at least.

Questions

  • Why IsSignatureCard is a boolean, maybe it could be a field with hero id instead or other field maybe?

Thank you so much for your work!

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.