0ldsk00l / cirugia Goto Github PK

After executing cirugia -v 2 -m 23 -s 10 on rom hacked with this, Nestopia still reports mapper being unsupported.

How do you feel about turning romheader into a bit field instead of using all the bitwise operations? This would make the code easier to read, and give the compiler a bit more freedom in optimizing the bitwise arithmetic.

Instead of

return romheader[6] & 0x04 ? 1 : 0;

this would allow us to instead write

return romheader.trainer;

I wouldn't mind working on a PR if this is something you are open to, but I wanted to check first as this would impact a lot of code.