0b10 / lumberjack Goto Github PK

This should be optional, and not required

The generic is applied to the context arg for the template, but it's not reflected in the corresponding logger.

Perhaps the logger could accept undefined input, and only throw if a message hasn't been set in the template.

@Level 55 a message is not logged when piped into pino-gris, even though a message key is present

The trace log also has no message present. Perhaps the same message can be attached to each logger, to make them more visually relatable - currently only the ID relates them. This will need some thought.

This is confusing, and leads the reader to think that args and result have actual undefined values. Perhaps remove these unless they are explicitly used.

A set displays as {} when stringified (consoleMode=true), but displays the full set when consoleMode=false.

An example is an invalid error, it will still throw if validation is switched off. This shouldn't happen.

Allow users to defined their own stringify functions in the configuration file.

This should display the contents of allowed values instead. Use a template string for all error messages in error classes, and do proper type checking for the given parameters.

Something like: `a reusable, generic template message: ${do type checking here}`

Display module paths in log messages.

"message is invalid" for an invalid template message isn't good enough. Check provide better messages for all errors.

Bind discrete logs together with a log ID.

An undefined message in the logger shouldn't throw, if it is defined in the template

const log = lumberjackTemplate({ message: "foo", modulePath: __filename });
log();

<srcRoot>/lib/loggers.js:92
   const message = messages.message || template.message;
                            ^
TypeError: Cannot read property 'message' of undefined
    at Object.exports.logMessage (<srcRoot>/lib/loggers.js:92:30)

Instead of just info, or debug, also include warn.