decode triggered although stopped about ngx-scanner HOT 4 CLOSED

Thanks for the research, will address this issue in the next release!

from ngx-scanner.

Thx for your fast response. I had a look at the commit and tested it locally. It's not solving the problem I mentioned.

The problem I'm referring to happens in the BrowserCodeReaderExt class. I will try to describe my use case a little bit in more detail:

• I'm adding the component and starting the camera (by setting the start input to true)
• As soon as I'm getting a response from the scan I'm stopping the camera (again by changing the start input to false - I even tried to call the stop method directly)
• the camera is stopped correctly (BrowserCodeReaderExt stop() is called)
• the stream is closed
• but now the callbackFn of the BrowserCodeReaderExt decode function returns a value and the check is done if the scan should only be done once
• if false (and it is false all the time) a new timeout is set and the decode is called again which leads to the mentioned error

A solution might be to not only check if the decode should be done once but also to check if the stream is still set:

if (!once && undefined !== this.stream) {
	setTimeout(function () { return _this.decodeWithDelay(callbackFn); }, this.timeBetweenScansMillis);
}

I have created a pull request (my first one on github) - so if you can have a look or give me feedback, I would appreciate it.

from ngx-scanner.

Thanks for the detailed analysis and the PR! Looks good to me, I merged it. Thanks! BTW: my first angular component and also my first active project on github as well 😉

from ngx-scanner.

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

from ngx-scanner.