Improving userInputs dictionnary feedback about zxcvbn HOT 8 CLOSED

I believe that the en one should then be There should not be any personal or site related data. and for the de version I'd go with Es sollten keine persönlichen oder seitenrelevanten Daten vorkommen. 😀

from zxcvbn.

You can override most of the stuff that was my goal.
Let's stick with site. Which means we have those translations:

en:
There should not be any personal or page related data.

de:
Es sollten keine persönlichen oder Seiten relevanten Daten vorkommen.

fr:
Your translation

nl-be:
@SimonBackx do you mind helping us out?

from zxcvbn.

Do you mind creating a PR for it?
Since Simon does not answer we can just use something like deepl for nl-be and someone can improve it later.
This way we can get this issue rolling 👍

from zxcvbn.

Vermijd persoonlijke of website gerelateerde woorden.

Is the Dutch one, sorry for the delay!

from zxcvbn.

Could we just list every forbidden words ? "There should not be any of these words: [...]" and enumerating userInputs list. Could be problematic if long list. Or maybe leave a specific tag that could be easily replaced by the dev implementing zxcvbn. That way the dev is in total control of the list showed in feedback, and may only show a smaller subset of a really long list.

from zxcvbn.

The list would be pretty weird and can get pretty quick out of hand. The dev already has full control of what is shown as feedback, as you can just edit the array of it:

import zxcvbnEnPackage from '@zxcvbn-ts/language-en'

const translations = zxcvbnEnPackage.translations
translations.warnings.userInputs = 'Your custom feedback for userInputs'

How about something like There should not be any personal or page related data.?

from zxcvbn.

oh great, didn't realize you could override. In this case yes the feedback is definitely better like this. I would emphasize something like "service" or "site" instead of "page"

from zxcvbn.

Great, for the fr part that should be: Le mot de passe ne doit pas comporter de données personnelles ou liées au site.

from zxcvbn.