RefreshValues does not return any error when node is dead. about zwavejs.net HOT 6 CLOSED

Hi @spudwebb

That is Driver side.
@AlCalzone, is that by design? as it would make sense to fail on Refresh for a dead node?

I'm wondering if this is Server side, mistakenly returning a success?

from zwavejs.net.

The driver doesn't return anything, but it also doesn't throw an error. I didn't want to fail the whole method when just a single query failed.
The server also doesn't return a success value:
https://github.com/zwave-js/zwave-js-server/blob/03405c02304c4555900c4fe1a5e7a873becfd11e/src/lib/node/message_handler.ts#L116C1-L119

from zwavejs.net.

The server also doesn't return a success value:

It does by default, if no exception occurred 😅
every call yields a success property, which denotes if an error occurred driver/server side, so that will make sense, given nothing is going wrong

from zwavejs.net.

I see, that was hidden somewhere else. I guess it could be an enhancement to collect the errors while querying and return them to be able to indicate that something went wrong.

from zwavejs.net.

@AlCalzone,
Do you want to transfer this as a future enhancement?, not sure I can add much here, I don't have the right to transfer issues 🤷

from zwavejs.net.

I'll close this as an upstream enhancement.

from zwavejs.net.